On Tue, 18 Mar 2008 17:10:55 +0300 Anton Vorontsov <[EMAIL PROTECTED]> wrote:
> > > > -/* VSC7385 Gigabit Switch support */ > > > +/* > > > + * VSC7385 Gigabit Switch support > > > + */ > > > +#define CFG_VSC7385_BASE 0xF0000000 > > > > What does this have to do with NAND? > > Nothing. I'm expanding VSC7385 comment to better separate it from > the NAND code. Most lengthy parts of the RDB config are using > > /* > * > */ > > as a logical separator. So did I. that's fine, it just makes patch review easier and less susceptible to comments like this if you keep your patches on-subject. Also, this patch doesn't apply cleanly to the top of u-boot-mpc83xx.git, because of the VSC7385 patches I applied last week. Can you rebase your patches to the top of the mpc83xx git tree? I just updated it to Wolfgang's top-of-tree. Kim ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
