Hi Michael Sorry to hear that. I have tried to give all my best and follow the style of the ml300 board, which was the closest board to mine. On FPGAs board I think that it is not a horrible idea to follow this style. Maybe you should consider to create an FPGA branch, where the generic drivers could be accepted. As I said, the FPGA hardware changes a lot and support a so changing hardware will be very difficult... Or just should not support FPGAs and its IP devices...
By the way: patches 1 2 and 6 follow the guidelines and don't add any generic driver patches 8 (except xparameters.h) follow the guidelines patch 6 could be redesined. You should be aware that driver/serial/serial_xuartlite.c does not compile for ppc440 without that patch Best regards On Thu, Jul 10, 2008 at 9:04 PM, Michal Simek <[EMAIL PROTECTED]> wrote: > Hi Ricardo, > > I read your patches in your weird style. > These style of patches never go to mainline. You use xilinx generated files > which is currently use only with ml300. > For example look at your xparameters.h there are a lot of values which are > not used. > If you want to add ml507 to mainline U-BOOT you have to change completely > handling style of xilinx board for ppc. > In next U-BOOT release I will clean ancient ml300. I want to remove a lot of > xilinx generic files. > > 100% NACK for these patches. > > The size of patches is due to your incorrect design strategy. > > Michal Simek > > > Hi List: > > This is my first contribution to u-boot. I have ported u-boot to the > ML507 Board by Xilinx. > http://www.xilinx.com/products/devkits/HW-V5-ML507-UNI-G.htm > > This boards includes an FPGA Virtex 5 FX with an embedded PowerPC 440. > > The port supports: > -Virtex 5 ppc440x5 > -XIlinx Interrupt Controller > -Xilinx I2C Controller (Interrupted mode) > -Xilinx Uart Lite (simple port) > -Xilinx LL_TEMA (Interrupted and SGDMA) > -Save environment on board eeprom > -DTT support for the ADT sensor on board (new hwmon driver) > -Dummy I2C driver (for testing purposes) > > This patch works against the last commit to the p4xx branch. > > I am a researcher of the Universidad Autonoma de Madrid, and this work > has been supported by Q-Technology ( http://qtec.com ) under a > Research Agreement. > > Any comment will be very welcomed. > > PS: I have divided the patch in four parts for the mailing list > -- > Ricardo Ribalda > http://www.eps.uam.es/~rribalda/ > > > -- Ricardo Ribalda http://www.eps.uam.es/~rribalda/ ------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
