On Sat, Jul 26, 2008 at 19:36, Jean-Christophe PLAGNIOL-VILLARD <[EMAIL PROTECTED]> wrote: >> > >> >> As I see it, CONFIG_AT91 would mean that you have a >> a certain class of peripherals which is developed for the >> AT91 range of processors (and is used by the AVR32 as well) >> The name is probably slightly misleading, but convenient. >> >> Not having this definition, will soon mean that you have statements >> like the following: >> >> #if defined(CONFIG_AT91RM9200) || \ >> defined(CONFIG_AT91SAM9260) || \ >> defined(CONFIG_AT91SAM9261) || \ >> defined(CONFIG_AT91SAM9263) || \ >> defined(CONFIG_AT91SAM9G10) || \ >> defined(CONFIG_AT91SAM9G15) || \ >> defined(CONFIG_AT91SAM9G20) || \ >> defined(CONFIG_AT91SAM9G41) || \ >> defined(CONFIG_AT91SAM9M10) || \ >> defined(CONFIG_AT91SAM9M11) || \ >> defined(CONFIG_AT91CAP9) || \ >> defined(CONFIG_AT572D940) >> >> This statement will have to be updated every time a new MCU is released. >> >> Having the statment >> #if defined(CONFIG_AT91) >> >> should definitely reduce the maintenance of drivers. > I fully agree with Ulf, we need to have a better CONFIG, but I'm not > sure that CONFIG_AT91 is the right one > > We have actually in the tree the following CPU > CONFIG_AT91CAP9 > CONFIG_AT91RM9200 > CONFIG_AT91SAM9260 > CONFIG_AT91SAM9261 > CONFIG_AT91SAM9263 > CONFIG_AT91SAM9RL > > and as mention Ulf are going to have more and more > > maybe we can use config related to the functionnality or the sub-class > CPU > ex : > CONFIG_MACB_INCLK
Agree. We can use "#if defined(CONFIG_AT91) && defined(CONFIG_MACB)" in net/eth.c and "#ifdef CONFIG_MACB_INCLK" in drivers/net/macb.c to simplify the previous *big* #ifdef. If everyone feels comfortable, I'll rewrite these parts and re-submit the patch. Thanks. > > Best Regards, > J. > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > U-Boot-Users mailing list > U-Boot-Users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/u-boot-users > ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users