On Mon, Jul 28, 2008 at 16:29, Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > "Hong Xu" <[EMAIL PROTECTED]> wrote: >> > maybe we can use config related to the functionnality or the sub-class >> > CPU >> > ex : >> > CONFIG_MACB_INCLK >> >> Agree. >> >> We can use "#if defined(CONFIG_AT91) && defined(CONFIG_MACB)" in >> net/eth.c and "#ifdef CONFIG_MACB_INCLK" in drivers/net/macb.c to >> simplify the previous *big* #ifdef. >> If everyone feels comfortable, I'll rewrite these parts and re-submit the >> patch. > > What does CONFIG_MACB_INCLK mean?
Per J's suggestion, use CONFIG_MACB_INCLK or some other thing to simplify the *big* ifdef in driver/net/macb.c >From the existing code, it seems that some boards (AT91CAP9, AT91SAM926[0,3]) need the CLKEN bit of EMAC_USRIO to be set, but others(if exist) do not need to. So in all boards that need this bit to be set, use a new CONFIG_MACB_XXX to denote this. > > Haavard > ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
