On 2016-07-05 13:56, Fabio Estevam wrote:
> On Tue, Jul 5, 2016 at 5:47 PM, Stefan Agner <ste...@agner.ch> wrote:
>> Sounds sensible. Would be the first use of
>> CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG in arch/arm/, but I guess that is
>> fine.
> To keep the consistency you could add
> CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG in your board file, just like the
> other boards.

Yeah sure, to define it I would put into our board config.

But what I ment here is it would be the first use of
CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG in _code_ under arch/arm. All other
uses of CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG are in board specific code
under boards/...

>> Note that CONFIG_SYS_SOC, which defines the environment variable "soc",
>> is currently defined "mx7" by default...
>> What do you think, do we want
>> 7 Sabre/Warp7? Put it in Common directly? Afaik those boards only exist
>> in a single variant, hence they always will load the same device tree
>> and therefore it wouldn't be really required to determine the SoC at
>> runtime.
> Correct: we don't need to use CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG for
> mx7sabresd/warp as they only use a single variant of the MX7 chip.

Ok, use it only in our config then.

U-Boot mailing list

Reply via email to