Hi Simon,
2018-04-23 5:10 GMT+09:00 Simon Glass <s...@chromium.org>: > Hi Masahiro, > > On 17 April 2018 at 20:38, Masahiro Yamada <yamada.masah...@socionext.com> > wrote: >> Currently, regmap_init_mem() takes udevice. This requires the node >> has already been associated with a device. It prevents syscon/regmap >> from behaving like those in Linux. >> >> Change the first argumenet to take the device node. >> >> Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> >> --- >> >> arch/arm/mach-aspeed/ast2500/sdram_ast2500.c | 2 +- >> drivers/core/regmap.c | 11 +++++------ >> drivers/core/syscon-uclass.c | 2 +- >> drivers/phy/meson-gxl-usb2.c | 2 +- >> drivers/phy/meson-gxl-usb3.c | 2 +- >> drivers/ram/rockchip/dmc-rk3368.c | 2 +- >> drivers/ram/rockchip/sdram_rk3188.c | 2 +- >> drivers/ram/rockchip/sdram_rk322x.c | 2 +- >> drivers/ram/rockchip/sdram_rk3288.c | 2 +- >> drivers/ram/rockchip/sdram_rk3399.c | 2 +- >> drivers/ram/stm32mp1/stm32mp1_ram.c | 2 +- >> drivers/reset/reset-meson.c | 2 +- >> include/regmap.h | 4 ++-- >> 13 files changed, 18 insertions(+), 19 deletions(-) > > Can you please add a simple test for regmap on sandbox? > No. Please stop this boiler-plate response. Simple tests for regmap already exist in test/dm/regmap.c regmap_init_mem() is not a new function, and it is tested through other function tests. You block patches several times before by making the contributors say "Sorry, I am busy". I am really busy, but I need to fix the misimplementation of syscon for Socionext drivers. Why should I be annoyed by additional work to fix the problem? -- Best Regards Masahiro Yamada _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot