On Mon, Jun 11, 2018 at 3:24 AM, Ley Foon Tan <lftan.li...@gmail.com> wrote:
> On Sat, Jun 9, 2018 at 5:59 AM, Simon Glass <s...@chromium.org> wrote:
>> Hi Ley Foon,
>> On 3 June 2018 at 23:19, Ley Foon Tan <ley.foon....@intel.com> wrote:
>>> Add reset ctrl to dwmmc socfpga, designware Ethernet and ns16550 serial
>>> A reset property is an optional feature, so only print out a warning and
>>> do not fail if a reset property is not present.
>>> If a reset property is discovered, then use it to deassert, thus bringing
>>> IP out of reset.
>>> v5 change:
>>> - Rename CONFIG_SPL_RESET_SUPPORT to CONFIG_SPL_DM_RESET
>>> - Change to use CONFIG_IS_ENABLED(DM_RESET) in reset.h
>>> - Added Simon's Reviewed-by in dwmmc, 16550 serial and designware emac
>> I think it is better to also include the earlier change logs, Also you
>> should have a change log on each patch as well as the cover letter.
> Okay, I can resend this.
Also, when you resend it, don't forget to include feedback you've
already gotten. v5 has dropped my ack from v3 of net: designware: Add
reset ctrl to driver. Also, if you want individual maintainers to take
in part of a series like this, it's not very natural. While these are
all related changes, they have no interdependencies. At very least, it
seems like the network driver change could either stand alone (and not
be in the series) or I should not be taking it by itself.
You don't have to resend just to add responses you've gotten, but if
you do resend for another reason, you need to add the feedback you've
gotten on earlier version (as long as they still apply).
>> The patman tool does this for you, so I suggest you take a look at that.
>>> v1: https://patchwork.ozlabs.org/cover/905519/
>>> v2: https://patchwork.ozlabs.org/cover/908667/
>>> v3: https://patchwork.ozlabs.org/cover/910018/
>>> v4: https://patchwork.ozlabs.org/cover/923883/
>>> Ley Foon Tan (5):
>>> reset: Rename CONFIG_SPL_RESET_SUPPORT to CONFIG_SPL_DM_RESET
>>> include: reset: Change to use CONFIG_IS_ENABLED(DM_RESET)
>>> mmc: dwmmc: socfpga: Add reset ctrl to driver
>>> serial: ns16550: Add reset ctrl to driver
>>> net: designware: Add reset ctrl to driver
>>> arch/arm/mach-stm32mp/Kconfig | 2 +-
>>> common/spl/Kconfig | 2 +-
>>> drivers/Makefile | 2 +-
>>> drivers/mmc/socfpga_dw_mmc.c | 17 +++++++++++++++++
>>> drivers/net/designware.c | 8 ++++++++
>>> drivers/serial/ns16550.c | 8 ++++++++
>>> include/reset.h | 2 +-
>>> 7 files changed, 37 insertions(+), 4 deletions(-)
> Ley Foon
> U-Boot mailing list
U-Boot mailing list