Hi Prabhakar, On Thursday, May 23, 2019 12:28, Prabhakar Kushwaha wrote: > > > > -----Original Message----- > > From: Prabhakar Kushwaha > > Sent: Thursday, May 23, 2019 9:20 AM > > To: Ran Wang <[email protected]> > > Cc: York Sun <[email protected]>; [email protected]; Albert Aribaud > > <[email protected]> > > Subject: RE: [RESEND][PATCH v2] armv8: Add workaround for USB erratum > > A- > > 050106 > > > > Dear Ran, > > > > > -----Original Message----- > > > From: Ran Wang > > > Sent: Thursday, May 23, 2019 9:16 AM > > > To: Prabhakar Kushwaha <[email protected]> > > > Cc: York Sun <[email protected]>; [email protected]; Albert > > > Aribaud <[email protected]> > > > Subject: RE: [RESEND][PATCH v2] armv8: Add workaround for USB > > > erratum > > > A- > > > 050106 > > > > > > Hi Prabhakar, > > > > > > On Tuesday, May 21, 2019 22:48, Prabhakar Kushwaha wrote: > > > > > > > > Dear Ran > > > > > > > <snip> > > > > > > > > > > USB3.0 Receiver needs to enable fixed equalization for each of > > > > > PHY instances in an SOC. This is similar to erratum A-009007, > > > > > but this one is for LX2160A, and the register value is different. > > > > > > > > > > Signed-off-by: Ran Wang <[email protected]> > > > > > --- > > > > > > > > This patch is for adding workaround for errata A-050106. > > > > But you are modifying erratum_a008997(). > > > > > > > > Please avid hidden changes in a patch. > > > > I will suggest to generate 2 patches one for A-050106 and other > > > > for > > > > a008997 > > > > > > Actually the information ' @@ -139,7 +139,8 @@ static void > > > erratum_a008997(void) ' > > > automatically generated by git is not quite right, the change I made > > > is within macro PROGRAM_USB_PHY_RX_OVRD_IN_HI rather than function > > > erratum_a008997(void) . > > > You can look into the src file > > > arch/arm/cpu/armv8/fsl-layerscape/soc.c > > > for details :) > > > > > > > > > @@ -139,7 +139,8 @@ static void erratum_a008997(void) > > out_be16((phy) + SCFG_USB_PHY_RX_OVRD_IN_HI, > > USB_PHY_RX_EQ_VAL_3); \ > > out_be16((phy) + SCFG_USB_PHY_RX_OVRD_IN_HI, > > USB_PHY_RX_EQ_VAL_4) > > > > -#elif defined(CONFIG_ARCH_LS2080A) || defined(CONFIG_ARCH_LS1088A) > > +#elif defined(CONFIG_ARCH_LS2080A) || defined(CONFIG_ARCH_LS1088A) > || \ > > + defined(CONFIG_ARCH_LX2160A) > > > > As per my understanding this change is being done in erratum_a008997 > > Let me know, if am not seeing it correctly. > > > > Thanks for showing me. > > You are right.. this change is in between static void erratum_a008997 and your > new function 😊
Yes, looks like Git has defect on this. Thanks. Regards, Ran _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
