On 11/7/19 9:41 AM, Ley Foon Tan wrote: > On Thu, Nov 7, 2019 at 4:33 PM Marek Vasut wrote: >> >> On 11/7/19 9:06 AM, Ley Foon Tan wrote: >>> On Thu, Nov 7, 2019 at 10:49 AM Marek Vasut wrote: >>>> >>>> On 11/7/19 3:10 AM, Ley Foon Tan wrote: >>>>> Convert reset manager for Gen5, Arria 10 and Stratix 10 from struct >>>>> to defines. >>>>> >>>>> Change to get reset manager base address from DT node instead of using >>>>> #define. >>>> >>>> It seems the patch also moves spl_early_init() around ? >>> Yes, because spl_early_init() initialize DT stuff, so it needs to be >>> called before we get base address from DT. >> >> That really should be documented in the commit message though. > Okay. >> >> [...] >> >>>>> +void socfpga_get_manager_addr(void) >>>> >>>> You should rename this function, a lot of blocks on the Gen5 are called >>>> <something>-manager . >>> Okay, will change it something like socfpga_get_base_addr(). >> >> If it's only used to retrieve the reset manager base, then it should say >> so in the function name. > socfpga_get_manager_addr() function will get base address for clkmgr, > rstmgr and sysmgr, not only reset manger.
Aha, OK, then that's fine as is. [...] _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
