Hi Rick, On Mon, Jul 20, 2020 at 10:48 AM Rick Chen <[email protected]> wrote: > > Hi Tom > > > From: Bin Meng [mailto:[email protected]] > > Sent: Friday, July 17, 2020 2:54 PM > > To: Pragnesh Patel > > Cc: Bin Meng; Rick Jian-Zhi Chen(陳建志); Simon Glass; U-Boot Mailing List; > > Sagar Kadam > > Subject: Re: [PATCH 1/5] sysreset: syscon: Don't assume default value for > > offset and mask property > > > > Hi Rick, > > > > On Fri, Jun 26, 2020 at 1:53 PM Pragnesh Patel <[email protected]> > > wrote: > > > > > > >-----Original Message----- > > > >From: Bin Meng <[email protected]> > > > >Sent: 23 June 2020 11:00 > > > >To: Rick Chen <[email protected]>; Simon Glass <[email protected]>; > > > >Pragnesh Patel <[email protected]>; Sagar Kadam > > > ><[email protected]>; U-Boot Mailing List <[email protected]> > > > >Cc: Bin Meng <[email protected]> > > > >Subject: [PATCH 1/5] sysreset: syscon: Don't assume default value for > > > >offset and mask property > > > > > > > >[External Email] Do not click links or attachments unless you > > > >recognize the sender and know the content is safe > > > > > > > >From: Bin Meng <[email protected]> > > > > > > > >Per the DT binding, <offset> is a required property. Let's abort the > > > >probe if it is missing. For the <mask> property, current codes assume > > > >a default value of zero, which is not correct either. > > > > > > > >Signed-off-by: Bin Meng <[email protected]> > > > >--- > > > > > > > > drivers/sysreset/sysreset_syscon.c | 14 ++++++++++++-- > > > > 1 file changed, 12 insertions(+), 2 deletions(-) > > > > > > Reviewed-by: Pragnesh Patel <[email protected]> > > > > Would you please take the remaining 3 patches soon? > > http://patchwork.ozlabs.org/project/uboot/list/?series=185161 > > May I ask for your opinions about these three SYSRESET patchs. If they > are OK to be pick up in my next PR, though they have been rejected in > previous riscv PR ? > https://www.mail-archive.com/[email protected]/msg375465.html >
Now the merge window for v2020.10 is open. It's OK to merge this now. Regards, Bin
