Dear Jason Liu, In message <[email protected]> you wrote: > > > Really not enough to justify a new driver. All functions are really > > copied from the old one. Please consider to adapt fsl_pmic.c instead of > > adding a slightly different new one. > > fsl_pmic is about freescale mc13892 and fsl_pmic.c is dedicated for fsl pmic > as you write this file, right? > > As I add the Dialog PMIC support, I do want to not add one new file, but I > find > it's not easy to add it and it will make the file very mess, so, I > decide not to touch > the original file and add one new file. The head of this file tell it > clear that this patch is > Based on drivers/misc/fsl_pmic.c.
Stefano is right. We cannot accept such duplication of code. Please merge into a single common driver. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected] "When people are least sure, they are often most dogmatic." - John Kenneth Galbraith _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
