Hi, Stefano, On Sat, Apr 23, 2011 at 3:45 PM, stefano babic <[email protected]> wrote: > Am 22/04/2011 16:50, schrieb Jason Liu: > > Hi Jason, > >>> As I can see now, this driver is quite a copy of fsl_pmic.c, with >>> slightly changes. Are you sure we cannot simply change the already >>> provided driver, adding support for the new chip ? >>> >>> I have not read the DA9053 datasheet, but from your patch it seems to me >>> that the relevant changes are: >>> - registers are 1 byte wide instead of 32 bit >>> - different size of register area >>> >>> Really not enough to justify a new driver. All functions are really >>> copied from the old one. Please consider to adapt fsl_pmic.c instead of >>> adding a slightly different new one. >> >> fsl_pmic is about freescale mc13892 and fsl_pmic.c is dedicated for fsl pmic >> as you write this file, right? > > It was for MC13892, but it is for MC13783 as well, used in i.MX31 boards. > >> >> As I add the Dialog PMIC support, I do want to not add one new file, but I >> find >> it's not easy to add it and it will make the file very mess, so, I >> decide not to touch >> the original file and add one new file. The head of this file tell it >> clear that this patch is >> Based on drivers/misc/fsl_pmic.c. > > I do not mind an issue related to set where the driver is coming from. > My concern is due to the fact that your patch is very similar (for the > i2c part) to the fsl_pmic.c file, and I want to avoid to have two > different driver making the same things, having then the necessity to > maintain both. At the end, this file expones only a common interface to > the board maintainers to access the pmic registers (via I2c or SPI as > well). Running diff on the two files I do not see a lot of differences. > >> >> If you still want me to include the DA9053 support into fsl_pmic, >> could you please >> extend the fsl_pmic support to easily add another vender's pmic support >> first? > > Really I have not understood your question. What do you mean ?
Then, Can you tell me how to add the dialog pmic support into fsl_pmi.c file which is dedicated for freescale mc13xxx? Thanks, > > Best regards, > Stefano Babic > > > -- > ===================================================================== > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [email protected] > ===================================================================== > _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
