Hi Jonas,

On 2026-07-08T22:05:26, Jonas Karlman <[email protected]> wrote:
> Kconfig: Add missing depends on xPL to xPL_ symbols
>
> xPL_<name> symbols should typically depend on the associated xPL symbol.
>
> Add missing depends on xPL to xPL_<name> symbols to avoid the xPL_<name>
> symbols being available when the associated xPL symbol is disabled.
>
> Signed-off-by: Jonas Karlman <[email protected]>
>
> common/Kconfig | 2 ++
>  lib/Kconfig    | 7 ++++++-
>  2 files changed, 8 insertions(+), 1 deletion(-)

> diff --git a/lib/Kconfig b/lib/Kconfig
> @@ -972,23 +973,27 @@ config SPL_LZO
>  config TPL_GZIP
> -     bool "Enable gzip decompression support for SPL build"
> +     bool "Enable gzip decompression support for TPL build"
> +     depends on TPL

The prompt fix is separate from adding the dependencies, so please can
you mention it in the commit message? Otherwise it looks like a stray
hunk.

> diff --git a/lib/Kconfig b/lib/Kconfig
> @@ -960,6 +960,7 @@ config TPL_LZMA
>  config VPL_LZMA
>       bool "Enable LZMA decompression support for VPL build"
> +     depends on VPL

BTW SPL_LZMA_SIZE_OPTIMIZATION (between SPL_LZMA and TPL_LZMA) has no
dependency at all, so it shows up in menuconfig even without SPL. It
fits the pattern this patch fixes and could get 'depends on SPL_LZMA'
while you are here. What do you think?

Reviewed-by: Simon Glass <[email protected]>

Regards,
Simon

Reply via email to