Hi again, On 7/9/2026 9:12 AM, Jonas Karlman wrote: > Hi Tom, > > On 7/9/2026 3:52 AM, Tom Rini wrote: >> On Wed, Jul 08, 2026 at 10:05:34PM +0000, Jonas Karlman wrote: >> >>> Change to depend on the xPL symbol instead of the SUPPORT_xPL symbol to >>> only make the xPL_SYS_I2C_LEGACY symbols available when xPL is enabled. >>> >>> Signed-off-by: Jonas Karlman <[email protected]> >>> --- >>> drivers/i2c/Kconfig | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig >>> index ab5af17858c8..125dc84819e6 100644 >>> --- a/drivers/i2c/Kconfig >>> +++ b/drivers/i2c/Kconfig >>> @@ -78,14 +78,14 @@ config SYS_I2C_LEGACY >>> >>> config SPL_SYS_I2C_LEGACY >>> bool "Enable legacy I2C subsystem and drivers in SPL" >>> - depends on SUPPORT_SPL && !SPL_DM_I2C >>> + depends on SPL && !SPL_DM_I2C >>> help >>> Enable the legacy I2C subsystem and drivers in SPL. This is useful >>> in some size constrained situations. >>> >>> config TPL_SYS_I2C_LEGACY >>> bool "Enable legacy I2C subsystem and drivers in TPL" >>> - depends on SUPPORT_TPL && !SPL_DM_I2C >>> + depends on TPL && !TPL_DM_I2C >>> help >>> Enable the legacy I2C subsystem and drivers in TPL. This is useful >>> in some size constrained situations. >> >> Building on the last email, I think these might need to be >> [ST]PL_FRAMEWORK not [ST]PL. >> > > I have mostly tested this series with additional changes that alias > putc()/puts() to printch()/printascii() in xPL builds when > common/console.o is unavailable and DEBUG_UART=y, patches that will > be sent as a separate series. > > It is possible such change may have hidden some latent issues, now > trying to push a branch that contains changes that ends at the patches > included in this series, but due to timeouts it was not possible prior > to sending this reply.
The CI pipeline [1] has now passed successfully for branch ci-kconfig [2]. [1] https://source.denx.de/u-boot/contributors/kwiboo/u-boot/-/pipelines/30642 [2] https://source.denx.de/u-boot/contributors/kwiboo/u-boot/-/commits/ci-kconfig Regards, Jonas > > This patch can also be dropped if it causes any issues, I only added it > after a search for SUPPORT_xPL and noticed that these depends seem to be > incorrect. SUPPORT_xPL is used to tell if xPL can be enabled or not, > not if xPL is enabled/disabled. > > Regards, > Jonas
