Hi Jonas, On 2026-07-08T22:05:26, Jonas Karlman <[email protected]> wrote: > Kconfig: i2c: Depend on correct xPL symbol > > Change to depend on the xPL symbol instead of the SUPPORT_xPL symbol to > only make the xPL_SYS_I2C_LEGACY symbols available when xPL is enabled. > > Signed-off-by: Jonas Karlman <[email protected]> > > drivers/i2c/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
> diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig > @@ -78,14 +78,14 @@ config SYS_I2C_LEGACY > config TPL_SYS_I2C_LEGACY > bool "Enable legacy I2C subsystem and drivers in TPL" > - depends on SUPPORT_TPL && !SPL_DM_I2C > + depends on TPL && !TPL_DM_I2C This also changes !SPL_DM_I2C to !TPL_DM_I2C, which fixes what looks like a copy-paste error, similar to the DM_SERIAL fix in the next patch. Please can you mention this in the commit message too? I checked the boards that enable TPL_SYS_I2C_LEGACY (the mpc85xx P1010RDB / P1020RDB / P2020RDB NAND configs) and none enables SPL_DM or TPL_DM, so there should no functional change, but it is worth recording that this dependency is also being corrected. With that (assuming you figure out what Tom raised): Reviewed-by: Simon Glass <[email protected]> Regards, Simon
