Hi Aristo, On 2026-07-21T15:21:05, Aristo Chen <[email protected]> wrote: > binman: Fix FIT image overlap issues for testFitSplitElf
> > Fix one binman test that has memory region overlap issue, the test case > needed to be updated to use non-overlapping memory layouts. This first sentence is a comma splice and 'needed to be updated' is past tense. Please use present/imperative, e.g. 'Update the fixture to use a non-overlapping memory layout so the two images no longer collide'. > > Fix one binman test that has memory region overlap issue, the test case > needed to be updated to use non-overlapping memory layouts. > > * Tests fixed: > - testFitSplitElf > > * Changes made: > 1. ELF section layouts: added elf_sections_tee.lds with different > address for TEE to avoid overlap with ATF address defined in > elf_sections.lds > 2. Makefile to properly build elf_sections_tee binary > 3. Update ftest.py to use separate ELF files for TEE vs ATF components > in split-elf operations. > > An upcoming commit will validate if the memory region is overlapped 'validate whether the memory regions overlap' reads better. > > Signed-off-by: Aristo Chen <[email protected]> > > tools/binman/ftest.py | 2 +- > tools/binman/test/Makefile | 8 ++++++-- > tools/binman/test/elf_sections_tee.c | 1 + > tools/binman/test/elf_sections_tee.lds | 32 ++++++++++++++++++++++++++++++++ > 4 files changed, 40 insertions(+), 3 deletions(-) > diff --git a/tools/binman/test/elf_sections_tee.lds > b/tools/binman/test/elf_sections_tee.lds > new file mode 100644 > index 00000000000..84a4123ccfe > --- /dev/null > +++ b/tools/binman/test/elf_sections_tee.lds > @@ -0,0 +1,32 @@ > + . = 0x00100010; > + _start = .; This is a verbatim copy of elf_sections.lds with only the two section addresses shifted up by 0x100000. Nothing ties the two files together, so a later edit to elf_sections.lds could silently diverge. A one-line comment noting that this mirrors elf_sections.lds at a higher base would keep them in sync. What do you think? Regards, Simon
