Hi Francesco, Frieder, Marek,
Thanks for the clarification. I used the older format from Linux's
Documentation/process/coding-assistants.rst. Commit 816d9992d9ed
("coding-assistants: simplify attribution") changed it to
"Assisted-by: LLM". I will use that format in v2.
Marek, agreed that using an assistant does not transfer responsibility
away from the human submitter. I am responsible for this submission,
and my Signed-off-by certifies the DCO.
For this patch, the source is the Linux driver
drivers/phy/freescale/phy-fsl-imx8mq-usb.c. The commit message identifies
the relevant Linux commits:
63c85ad0cd81 ("phy: fsl-imx8mp-usb: add support for phy tuning")
e75d564f6466 ("phy: fsl-imx8mq-usb: add i.MX95 tuning support")
The Linux source and the destination U-Boot driver both carry
GPL-2.0+ SPDX identifiers. The tuning helpers and conversions can be
checked directly against the Linux implementation.
To clarify the assistant's role: it helped port those routines to
U-Boot and draft the commit message. I reviewed the resulting changes
against the Linux source, including the i.MX95-specific conversions.
I also checked the i.MX95 TXVREF setting on hardware. With the patch
applied, the TXVREF_TUNE field in PHY_CTRL3 reads 8 for
fsl,phy-tx-vref-tune-percent = 100, matching the i.MX95 conversion
rather than the value 3 produced by the generic converter. These
register readings are included in the patch notes below the "---"
separator.
Thanks,
Tom
