FIT_ALGO_PROP is defined once with the hash and signature node
properties and a second time, with the same value, in the cipher node
block added by commit 7298e422504e ("mkimage: fit: add support to
encrypt image with aes"). The identical redefinition compiles silently,
which is how it went unnoticed, but it suggests a separate cipher
property where there is none: the 'algo' property name is shared by
hash, signature and cipher nodes. Keep the first definition only.

Signed-off-by: Aristo Chen <[email protected]>
---

Changes in v2:
    v2: new patch

 include/image.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/image.h b/include/image.h
index d991b4c2bc3..d80834049e5 100644
--- a/include/image.h
+++ b/include/image.h
@@ -1158,7 +1158,6 @@ int booti_setup(ulong image, ulong *relocated_addr, ulong 
*size,
 
 /* cipher node */
 #define FIT_CIPHER_NODENAME    "cipher"
-#define FIT_ALGO_PROP          "algo"
 
 /* dm-verity node */
 #define FIT_VERITY_NODENAME    "dm-verity"
-- 
2.43.0

Reply via email to