On Tue, 22 Sep 2026 12:36:20 +0000, Aristo Chen wrote:
> Link to v1:
> https://lore.kernel.org/u-boot/[email protected]/
>
> Changes in v2 (from Simon's review of v1, plus one cleanup noticed while
> addressing it):
>
> - new patch 1: drop the duplicate FIT_ALGO_PROP definition in the
> cipher node block of include/image.h, noticed while adding the cipher
> property defines requested in review.
> - patch 2 (was 1): add FIT_IV_HINT and FIT_IV_PROP to include/image.h
> and use them in fit_image_setup_cipher(). Non-functional cleanup, so
> the Reviewed-by is kept.
> - patch 3 (was 2): fit_resolve_image_data() skips its own pack and
> rewrite when re-processing a FIT that needs nothing resolved, while
> still validating every reference; reject image-data combined with a
> complete external data reference before the import when compiling a
> source file, where the combination cannot be legitimate, while
> re-processing keeps import-then-compare for the resolved form;
> complete the kernel-doc of the three new helpers, with the cipher
> check describing the source-file and re-processed cases separately;
> explain in the kernel-doc and at the remaining check why it runs
> after the import; add FIT_DATA_SIZE_UNCIPHERED_PROP and use the
> property defines.
> - patch 5 (was 4): the commit message now states that it completes the
> validation for the new property rather than fixing a pre-existing
> problem, and the kernel-doc of fit_image_effective_data() gains its
> parameter and return descriptions. Comment-only, so the Reviewed-by
> is kept; still a separate patch to stay reviewable on its own.
> - patch 6: new, user documentation with a worked example under
> doc/usage/fit/.
> - patch 7 (was 5): two cases for the complete offset and position forms
> of the mixing check; the Reviewed-by is dropped because of the added
> cases.
> - patch 4 (was 3): unchanged.
>
> [...]
Applied to u-boot/main, thanks!
[1/7] include: image: drop the duplicate FIT_ALGO_PROP definition
commit: 15b4b73766f9eb9c42e67c81b6585cf68e4699e5
[2/7] tools: mkimage: use an explicit iv from the cipher node when encrypting
commit: d0215d8718dab91a964d3989f143156f121211c5
[3/7] tools: mkimage: resolve image-data references between FIT images
commit: 195f273b6c86a42af6bca8c830f9ac0c9bb920dd
[4/7] tools: mkimage: share the external-data region between image-data images
commit: 4436d98341a6a8862ac73e121cd56b7031b38030
[5/7] tools: mkimage: include image-data sharers in the load overlap check
commit: d510292811e352f21ec358647305fabc53d14e06
[6/7] doc: fit: document shared image data through the image-data property
commit: 3272136ca701ac37402df2d34e6093cb53a9a6ba
[7/7] test: py: add tests for the FIT image-data property
commit: baf80458c7fe3d3bf67cd6d3ec11800bbe4003be
--
Tom
