On 2026-09-18T10:52:27, Alexey Charkov <[email protected]> wrote: > lib: Build xxhash in the SPL phase > > SPL_ZSTD selects XXHASH, but xxhash.o is built from inside the > ifndef CONFIG_XPL_BUILD block, so it never reaches an SPL link. zstd's > decompressor calls xxh64_* from code that survives --gc-sections, so > today the option only builds because nothing in SPL calls > zstd_decompress() and the whole library is discarded. The first caller > would fail to link. > > Give xxhash its own phase symbol and build rule, the way the other > compression libraries already have, and note in the SPL_ZSTD help how > much heap the decompressor wants, since that is the other thing which > may stop it from working. > > Signed-off-by: Alexey Charkov <[email protected]> > Reviewed-by: Tom Rini <[email protected]> > > lib/Kconfig | 10 +++++++++- > lib/Makefile | 3 ++- > 2 files changed, 11 insertions(+), 2 deletions(-)
Reviewed-by: Simon Glass <[email protected]>
