Hi Alexey, On 2026-09-18T10:52:27, Alexey Charkov <[email protected]> wrote: > sandbox: spl: Enable zstd > > Nothing in the tree had SPL_ZSTD set, so nothing noticed that it could > not link. Turn it on where the SPL FIT loader is exercised, so a build > says so next time. > > Signed-off-by: Alexey Charkov <[email protected]> > > configs/sandbox_spl_defconfig | 1 + > 1 file changed, 1 insertion(+)
> diff --git a/configs/sandbox_spl_defconfig b/configs/sandbox_spl_defconfig > @@ -230,6 +230,7 @@ CONFIG_RSA_VERIFY_WITH_PKEY=y > CONFIG_ZSTD=y > CONFIG_SPL_LZMA=y > +CONFIG_SPL_ZSTD=y I built sandbox_spl with this and it does what the commit message says: zstd and xxhash end up in the SPL image via image_decomp() and the SPL tests still pass. But this is only a link test. Nothing actually runs zstd_decompress() in SPL, so the 94KB workspace allocation and the SPL_ZSTD_LIB_MINIFY build are not exercised, and zstd is the main point of this series. The previous patch already has create_fit() taking a compression name, with image_compression() choosing it, so please can you add FIT_INTERNAL_ZSTD and FIT_EXTERNAL_ZSTD cases with a canned blob, as is done for lzma_compressed? That would also check the xxhash linkage at runtime. You would need image_supported() to check CONFIG_SPL_ZSTD for those, and do_spl_test_load() to pick the blob by type rather than assuming LZMA. That could go in this patch, or a following one. Regards, Simon
