On Tue, Oct 13, 2026 at 10:45:09AM +0200, Benoît Monin wrote: > On Friday, 2 October 2026 at 17:29:35 CEST, Tom Rini wrote: > > On Fri, Oct 02, 2026 at 03:02:24PM +0200, Benoît Monin wrote: > > > > > Add an SDHCI driver for the DesignWare Mobile Storage Host Controller > > > (DWC MSHC) integrated in the Metanoia MT2824 SoC. It supports eMMC up to > > > HS400/HS400ES and SD cards, and implements the MMC driver model. > > > > > > The controller is a DWC MSHC instance, but its PHY programming, > > > voltage/speed-mode handling and tuning model are silicon-specific > > > and differ from the existing DWC MSHC drivers. > > > > > > The PHY pad drive strength, receiver select and weak-pull settings > > > depend on the card type (eMMC vs SD) and are re-applied on every ios, > > > whereas snps_sdhci.c uses fixed pad values. > > > > > > High-speed modes force 1.8V signalling and HS400 uses an explicit PHY > > > DLL lock sequence (set_control_reg()/set_ios_post()), which snps_sdhci.c > > > does not implement. > > > > > > Tuning relies on the generic SDHCI core tuner, whereas snps_sdhci.c uses > > > the hardware auto-tuning block. > > > > > > Keeping a dedicated driver avoids per-variant branches in the shared > > > DWC MSHC drivers, matching how snps_sdhci.c, adi_sdhci.c and > > > cv1800b_sdhci.c are already split in U-Boot. > > > > > > Signed-off-by: Benoît Monin <[email protected]> > > [snip] > > > +static const struct udevice_id metanoia_sdhci_ids[] = { > > > + { .compatible = "metanoia,mt2824-dwcmshc" }, > > > + { /* sentinel */ } > > > +}; > > > > I don't see this compatible in Linus' tree currently, so what's the > > status on upstreaming all of the device tree parts? Thanks. > > > We are currently preparing a first patch series for Linux, but it has not > been posted yet.
I'd really like to see that get posted and commented on, so we don't have to have churn here later if there's changes requested. -- Tom
signature.asc
Description: PGP signature
