Hi Chen,
On Thu, 8 Oct 2026 09:35:18 +0800, Chen Huei Lok
<[email protected]> wrote:
From: Tien Fong Chee <[email protected]>
Enhanced the generic firmware loader to support QSPI RAW partition
loading. This would enable FPGA configuration bitstream loading
from QSPI RAW partition to program FPGA.
Patch 01/15 commit message oversells FPGA bitstream use
Please reword to QSPI RAW offset load; mention DDR cal backup (and
optional FPGA) as consumers
diff --git a/drivers/misc/fs_loader.c b/drivers/misc/fs_loader.c
@@ -183,0 +205,5 @@ static int fw_get_filesystem_firmware(struct udevice *dev)
+ firmwarep->offset, firmwarep->size, &actread);
+ else if (plat->data_type == DATA_RAW) {
+ if (IS_ENABLED(CONFIG_SPI_FLASH)) {
+ ret = spi_flash_read_dm(plat->flash, firmwarep->offset,
+ firmwarep->size,
Prefer IS_ENABLED over #ifdef where checkpatch still warns
Please convert remaining #ifdef sites called out by checkpatch
[...]
diff --git a/include/fs_loader.h b/include/fs_loader.h
@@ -31,2 +56,5 @@ struct phandle_part {
* @mtdpart: MTD partition for ubi partition.
* @ubivol: UBI volume-name for ubifsmount.
+ * @enum data_flags: Data type (RAW or filesystem).
+ * @struct sf_config: Serial flash configuration.
+ * @struct spi_flash: Information about a SPI flash.
device_plat kerneldoc title still says struct phandle_part
Please fix the kerneldoc title to struct device_plat
Best regards,
Tien Fong
