Hi Simon, On Fri, Oct 16, 2026 at 5:02 PM Simon Glass <[email protected]> wrote: > > Hi Anirudh, > > On , Anirudh Srinivasan <[email protected]> wrote: > > > Let me propose a different solution here: What if I just drop this and > > the previous commit (support 16-bit reads on VGA port)? > > > > > If I implement custom ops in the Aspeed VGA driver for all > > BE_(in|out)(b|w|l) calls, then I don't need to touch this function at > > all. All the port/range checking needed can be handled in these ops > > that biosemu will call. The existing biosemu code will just look for > > the custom ops in the driver and fallback to the existing generic > > version. > > Either approach is fine with me. One thing to bear in mind: ports > 0x3B4/0x3B5/0x3BA and 16-bit CRTC accesses are not Aspeed-specific, > they are standard VGA behaviour that any VBIOS may rely on, so fixing > them in the generic emulator benefits every future user. If you prefer > the ops route, please add the hook mechanism itself as a generic > biosemu feature (not Aspeed-only) and keep only the truly > board-specific quirks in the driver. Otherwise the next VBIOS we meet > will hit the same gap.
I'll keep these changes in then. > > I'm ok with whichever you choose, as long as the generic path still > works for non-Aspeed callers. > > Regards, > Simon
