Comment on attachment 8370331
WIP patch 2
Review of attachment 8370331:
-----------------------------------------------------------------
I'm OK with this approach. I'd like to see test cases for both a single
folder and a nested folder - for example:
make folder A
move A to trash
make new A
move A to trash
make new A
make new A/B
move A to trash
make sure trash has A and A-1 and A-2 and A-2/B
We don't need to test all those combinations for every message store
type, but we should at least test the copyFolder(...aNewName) parameter
works once on each store type.
::: mailnews/local/src/nsLocalMailFolder.cpp
@@ +1732,5 @@
> + while (1) {
> + rv = CheckIfFolderExists(newFolderNameUnderTrash, this, NULL);
> + if (rv == NS_MSG_FOLDER_EXISTS) {
> + newFolderNameUnderTrash.Assign(folderName);
> + newFolderNameUnderTrash.AppendLiteral("-"); // do we want this
> localizable? "<folder>-<SeqNo>"
I don't think this needs to be localizable.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/214366
Title:
Can't delete a folder if Trash already contains a folder of the same
name
To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/214366/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
