Hi Robie. > Won't that cause an unwanted conffile prompt on future release upgrade?
There will be no later future bad conffile prompt if the file isn't modified. This is because old/new conffile most likely will match the registered default checksum and therefore are upgraded without prompt. Instead it will change behavior "on upgrade" just as it already does on a F->G upgrade due to the new default being in Groovy. > What if a user installs this update, has a modified /etc/default/gpsd, but doesn't see the prompt? Will that system not receive this fix? yes, it is essentially a "fix of the conffile", therefore if someone skips the conffile update he will stay unfixed. Behavior will not change no matter if he "does update the conffile or not". In both cases USBAUTO will stay "off". It will just be more readable and usable if there is an explicit off setting in the conffile. > For the SRU, would it be better to adjust /lib/systemd/system/[email protected] to handle a not-set USBAUTO variable No as we'd further derive from how upstream, guides and other references will describe it. > could you expand on the "Impact" section Done ** Description changed: [Impact] - * [email protected] uses a variable that isn't defined + * [email protected] uses a variable that isn't defined - * backport changes to define this + * backport changes to define this - * >=Groovy set default to true, but we will set false for Focal to not - change behavior on SRU (adding the variable still is useful as people - can modify it much more easily than adding - or knowing about - it) + * >=Groovy set default to true, but we will set false for Focal to not + change behavior on SRU (adding the variable still is useful as people + can modify it much more easily than adding - or knowing about - it) + + * Currently users in Focal have no indicator to know about this tunable. + Adding it to the default conffile but in the mode that matches current + focal behavior will help. [Test Case] - * After install check if /etc/default/gpsd contains any definition for - USBAUTO - - $ grep USBAUTO /etc/default/gpsd + * After install check if /etc/default/gpsd contains any definition for + USBAUTO + + $ grep USBAUTO /etc/default/gpsd [Regression Potential] - * This particular change replaces a non existent variable with the - default. In future releases this is set to true, but for the backport - we will set false to match and not change the behavior focal was - released with. Due to that no change/regression should occur as behavior - isn't changed. - + * This particular change replaces a non existent variable with the + default. In future releases this is set to true, but for the backport + we will set false to match and not change the behavior focal was + released with. Due to that no change/regression should occur as behavior + isn't changed. [Other Info] - - * This is accepted in Debians packaging git, if not in Groovy in time I'll - need to put an 3.20-8ubuntu1 there, but I can preparing the SRU - independent to that. + + * This is accepted in Debians packaging git, if not in Groovy in time I'll + need to put an 3.20-8ubuntu1 there, but I can preparing the SRU + independent to that. --- - - gpsd needs to ship packaging/deb/etc_default_gpsd as default instead of debian/gpsd.default + gpsd needs to ship packaging/deb/etc_default_gpsd as default instead of + debian/gpsd.default Newer options are only added here: $ cat packaging/deb/etc_default_gpsd # Default settings for gpsd. # Please do not edit this file directly - use `dpkg-reconfigure gpsd' to # change the options. START_DAEMON="true" GPSD_OPTIONS="" DEVICES="" USBAUTO="true" GPSD_SOCKET="/var/run/gpsd.sock" But # Devices gpsd should collect to at boot time. # They need to be read/writeable, either by user gpsd or the group dialout. DEVICES="" # Other options you want to pass to gpsd GPSD_OPTIONS="" Some scripts depend on that e.g. ubuntu@ubuntu:~$ cat /lib/systemd/system/[email protected] ... ExecStart=/bin/sh -c "[ \"$USBAUTO\" = true ] && /usr/sbin/gpsdctl add /dev/%I || :" ExecStop=/bin/sh -c "[ \"$USBAUTO\" = true ] && /usr/sbin/gpsdctl remove /dev/%I || : -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1873415 Title: gpsd needs to ship packaging/deb/etc_default_gpsd as default instead of debian/gpsd.default To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gpsd/+bug/1873415/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
