I reviewed the Oracular debdiff. I can confirm it matches the upstream
"release/core91" branch (plus the Debian/Ubuntu additions in debian/).

As stated in the bug description, this is the same version as uploaded to 
Plucky, but with 3 patches dropped:
"""
-  * Fix build against v6.12-rc2 (LP: #2083994)
-    - backport: [tree-wide] finally take no_llseek out
-    - backports: netdev_features: convert NETIF_F_NETNS_LOCAL to
-      dev->netns_local
-    - backports: move asm/unaligned.h to linux/unaligned.h
"""
That makes it a "upstream backport" using an "ubuntu0" revision:
1:0~91.12629-gite112ecce-0ubuntu0~24.10.1

I wonder if there's any technical reason for dropping those 3 patches? If not, 
I'd suggest making it a real backport from Plucky, so that we have the exact 
same version in Plucky and Oracular, which should make maintenance much easier. 
This would then use a slightly different version string (to match Plucky's 
"ubuntu1" revision):
1:0~91.12629-gite112ecce-0ubuntu1~24.10.1

Furthermore, there's one slight difference in
debian/patches/0015-backports-genetlink-hold-RCU-in-genlmsg_mcast.patch,
which is linked to bug #2083994, but bug #2085453 (without any other,
logical changes). What's the reason for that? I'd expect that patch to
address exactly one issue, which should be the same in both cases.


Finally, this is a "full-version-backport", moving Oracular from v89 to v91, 
and I can see the urgency of failing kernel builds. Unfortunately, I couldn't 
find any SRU exception for backport-iwlwifi-dkms, and I'm unclear of how this 
change would match the SRU policy. It has been a rejection reason in the past 
(https://bugs.launchpad.net/ubuntu/+source/backport-iwlwifi-dkms/+bug/2046871/comments/14).
 So not sponsoring it, yet...

You-Sheng, can you please make a case for how this matches the SRU
policy or point us to the corresponding SRU exception? And potentially
address or explain my other remarks from above?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2085453

Title:
  New upstream core91 release

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/backport-iwlwifi-dkms/+bug/2085453/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to