>> also fine tune PID sequence > Please make this a minimal cherry-pick, or otherwise justify why changing the > sequence is required in an > SRU. See: > https://documentation.ubuntu.com/sru/en/latest/reference/requirements/#general-requirements > for-all-srus "Changes must be minimal" and > https://documentation.ubuntu.com/sru/en/latest/explanation/ > requirements/#explanation-minimal
As you saw this comes from an upstream change, not doing it now it implies that all next cherry-picks will be more annoying to do and more risky (as they imply further manual changes on something has been already tested and committed upstream). Also all that list is fully tested by libfprint test suite, so that if one string is missing the build will fail, reason why reordering them is completely fine. Now, cna we just rely on this comment on the related bug as rationale or want us to re-upload it, explaining why it matters? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2097831 Title: Support Synaptics fingerprint device with ID 06cb:0107 and 06cb:0108 To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/2097831/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
