Public bug reported: [Impact]
In Noble, when enabling the "Group by type" option in the menu, the icons disappear and the journal shows this error: DING: (gjs:727738): Gjs-CRITICAL **: 18:23:42.468: JS ERROR: TypeError: item.updateIcon() is undefined DING: _sortAllFilesFromGridsByKindStacked@/usr/share/gnome-shell/extensions/[email protected]/app/desktopManager.js:2061:18 DING: doStacks@/usr/share/gnome-shell/extensions/[email protected]/app/desktopManager.js:1930:14 DING: DesktopManager/this._settingsId<@/usr/share/gnome-shell/extensions/[email protected]/app/desktopManager.js:181:26 DING: @/usr/share/gnome-shell/extensions/[email protected]/app/ding.js:206:13 Disabling the option doesn't fix it; it is required to kill the DING application too. The problem is because desktopManager.js calls asynchronously the `updateIcon()` method, but that method just synchronously calls the asynchronous method `_updateIcon()`. The upstream fix, already available in Questing, consists on returning the value of the call to `_updateIcon()` [Test plan] - Right click on an empty space in the desktop - In the popup menu select "Sort by..." - In the submenu, select "Keep grouped by type" option If the bug exists, the desktop will become empty. Instead, if the bug has been fixed,the desktop will show grouped icons. [Where problems could occur] The `updateIcon()` method is called only in two places, both in the `desktopManager.js` file: one when the `icon-size` gsetting property changes, and another when the files are sorted to be stacked. Thus, if the patch breaks something, in the worst case it will be the desktop refresh if the `icon-size` setting is changed, since the other case is already broken. ** Affects: gnome-shell-extension-desktop-icons-ng (Ubuntu) Importance: Undecided Assignee: Sergio Costas (rastersoft-gmail) Status: New ** Affects: gnome-shell-extension-desktop-icons-ng (Ubuntu Noble) Importance: Undecided Status: New ** Tags: noble ** Also affects: gnome-shell-extension-desktop-icons-ng (Ubuntu Noble) Importance: Undecided Status: New ** Tags added: noble -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2131690 Title: grouping by type fails in Noble To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-shell-extension-desktop-icons-ng/+bug/2131690/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
