It seems simple enough. I have a few questions comments:

1) You should probably install the service to /usr/lib/systemd, not 
/lib/systemd I think
2) I don't think run_sbsa_gwdt_selective_enablement should be in the default 
PATH (Maybe /usr/libexec or something? Not sure)
3) The version number should have "ubuntu" in it. I think by my reading of 
https://documentation.ubuntu.com/project/how-ubuntu-is-made/concepts/version-strings/#version-native-packages
 the current expectation is that the version number would be something like 
"1.0ubuntu".
4) What is your plan for getting this into images? I see you have set Priority: 
important which would result in it being part of almost all images we make, is 
that appropriate?

I also can't help wondering if there is a better way. I assume you've
asked the kernel team if they would reconsider the blacklisting of this
module?

Sorry that's a lot of questions for a very simple package!

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2132001

Title:
  [needs-packaging] dgx-desktop-sbsa-gwdt-loader

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/2132001/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to