Thank you for the review of this tricky package. I've addressed all your comments: * d/changelog is detailed and explains how I carried it over from the prior packaging work * d/control still has Rules-Requires-Root: no, because indeed I maintain it on a PPA for noble at the moment. * I changed the debhelper compat. That brought a ton of dh_missing warnings, which made me realize I should recheck what upstream is shipping in their releases. I add a few things in my .install files to reflect that, as well as a not-installed file. * d/dxc-docs.docs is now removed, it was a leftover from lunarG.
I also noticed some lintian warning that I had (surprisingly) not seen before, so I sneaked in a few fixes (hardening, copyright) I've pushed it to another branch so that you can see the changes nicely as a PR: https://code.launchpad.net/~antoinelassagne/ubuntu/+source/directxshadercompiler/+git/directxshadercompiler/+merge/499433 The code is now on branch `review-from-seb`: https://code.launchpad.net/~antoinelassagne/ubuntu/+source/directxshadercompiler/+git/directxshadercompiler/+ref/review-from-seb I've also reuploaded the package as a +ppa1: https://launchpad.net/~antoinelassagne/+archive/ubuntu/dxc/+packages -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2127245 Title: [needs-packaging] directxshadercompiler To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2127245/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
