Thanks for the work. I've some review comments * debian/changlog
- it's confusing for a new package to have such a long changelog, it would be nice to explain the situation rather than only stating "New release update". Something around the line of "uploading to the Ubuntu archive, based on the package maintainer in <place> by <maintainer>" * debian/control - is the intend to backport to older series? If not then the "Rules- Requires-Root: no" in debian/control isn't needed, that's the default on newer dpkg versions (since questing) - > debhelper (>= 13), > debhelper-compat (= 10), is slightly buggy, if you Build-Depends on debhelper-compat you don't need to also have a Depends on debhelper. If you do the versions should match. We have debhelper 13 in 22.04, do you plan to backport to old series? If no why not bumping the compat to 13 (and then removing the debhelper Depends)? - nitpick but you can remove "Priority: optional" if you bump Standards- Version to 4.7.3 * debian/dxc-docs.docs lists README.Debian which seems to no be provided in the source? Those are mostly nitpicks, good work overall! I didn't review debian/copyright in details yet -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2127245 Title: [needs-packaging] directxshadercompiler To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2127245/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
