On Mon, Nov 16, 2009 at 12:24:08PM +0100, Pascal de Bruijn wrote:
>
> Sorry, but you didn't bother to click the other tabs... Just because
> you didn't look doesn't mean it's by definition confusing.
Pascal, what definition of confusing can there be, other than a user
looking at it and being confused? Please don't be dismissive of other
people's reactions. Finding out when things are not intuitive to users
is helpful for development.
I will add that it's frustrating, too (because I find it so!) because
unlike every other part of the UFRaw UI, you can't check at a glance
what it's doing by skimming through the main tabs. Of course, there are
a lot of settings, so a better way of presenting them might be hard to
find without making other things awkward at the same time. But we should
think about it rather than dismissing the problem.
> Like I said before, I think it's a good idea to make the distortion
> correction the first tab...
I agree, since this is the only correction that actually seems to be
given for any lenses in the database. Attached is a patch to do that,
with the order becoming: distortion, geometry, vignetting, CA.
> The only thing that's confusing here is that the correction values are
> reset to 0, after the lens model changes. It would be nice if these
> values would be remembered.
This happens because the code is only keeping a single
lfLensCalibDistortion struct in the configuration, with storage for a
single set of correction terms. I suggest we keep an array of these in
the UI code (they shouldn't be needed for batch processing), indexed by
the distortion model type, so the user can apply settings with different
models and switch between them to compare, or switch to the None model
and back without losing the settings.
The same could be done for the other types of correction. Any other
thoughts before I code this?
Martin
diff --git a/ufraw_lens_ui.c b/ufraw_lens_ui.c
index 0b50d3f..36c70d4 100644
--- a/ufraw_lens_ui.c
+++ b/ufraw_lens_ui.c
@@ -1160,19 +1160,19 @@ void lens_fill_interface (preview_data *data, GtkWidget *page)
ufraw_lensfun_init(data->UF);
camera_set(data);
- subpage = notebook_page_new(subnb,
- _("Lateral chromatic aberration"), "tca");
- fill_tca_page(data, subpage);
-
- subpage = notebook_page_new(subnb, _("Optical vignetting"), "vignetting");
- fill_vignetting_page(data, subpage);
-
subpage = notebook_page_new(subnb, _("Lens distortion"), "distortion");
fill_distortion_page(data, subpage);
subpage = notebook_page_new(subnb, _("Lens geometry"), "geometry");
fill_geometry_page(data, subpage);
+ subpage = notebook_page_new(subnb, _("Optical vignetting"), "vignetting");
+ fill_vignetting_page(data, subpage);
+
+ subpage = notebook_page_new(subnb,
+ _("Lateral chromatic aberration"), "tca");
+ fill_tca_page(data, subpage);
+
lens_set(data, CFG->lens);
if (CFG->lensfunMode == lensfun_none) {
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
ufraw-devel mailing list
ufraw-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ufraw-devel
