Dne pondělí 01 Srpen 2011 23:21:04 Vladimir Nadvornik napsal(a): > Dne neděle 31 Červenec 2011 20:21:30 Vladimir Nadvornik napsal(a): > > Hi, > > > > Is the lensfun configuration in id files supposed to work in current CVS? > > > > I have the following problem: > > > > 1. use ufraw from CVS, delete the ~/.ufrawrc > > 2. run > > > > ./ufraw IMG_1102.CR2 > > > > (the file is from Canon S95) > > ufraw identifes the lens and the correction is correctly applied > > > > 3. click on auto-crop > > 4. set Create ID -> Only > > 5. Save > > 6. Run > > ./ufraw IMG_1102.ufraw > > > > the correction is not applied and the lens description is empty > > > > > > Is anybody working on this? I could try to debug it if needed. > > I have found the problem. > > When an ID file is read, the method LensModel::Event is called too > early, when Lensfun.Camera is not set. > > The Lensfun.LensDB()->FindLenses on ufraw_lensfun.cc line 145 then > sometimes returns NULL and the LensModel is left empty. > > I have tested this: > > Sigma 10-20 on Canon camera => FAIL > Canon 100mm on Canon camera => works OK > Canon S95 compact camera => FAIL > > The lens name is apparently not sufficient in all cases and the camera name > is required too. >
I was trying to debug it further. I think that during loading of an ID file, UFRaw should not search the lens in the database at all, but just use the values from the ID file. But then there is a problem with missing lens crop factor, which is not stored in the ID file. I think that it should be added. Currently it first takes all lens parameters from the database and then overwrites the values that are present in the ID file. This can lead to inconsistent results when the lensfun database is updated (a change of lens crop factor is quite likely, for example when a full frame lens is first measured with smaller sensor and later on full frame camera). So I think that UFRaw should use either one set of parameters or another, but don't combine values from both. And the set in ID file is incomplete. Vladimir ------------------------------------------------------------------------------ BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The must-attend event for mobile developers. Connect with experts. Get tools for creating Super Apps. See the latest technologies. Sessions, hands-on labs, demos & much more. Register early & save! http://p.sf.net/sfu/rim-blackberry-1 _______________________________________________ ufraw-devel mailing list ufraw-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ufraw-devel
