> I was trying to debug it further. I think that during loading of an ID file, > UFRaw should not search the lens in the database at all, but just use the > values from the ID file. But then there is a problem with missing lens crop > factor, which is not stored in the ID file. I think that it should be added.
There is more than the crop factor in the LensDB, there are also the valid focal lens, etc. I found several bugs in this code path, hopefully I will have a patch ready soon. > Currently it first takes all lens parameters from the database and then > overwrites the values that are present in the ID file. This can lead to > inconsistent results when the lensfun database is updated (a change of lens > crop factor is quite likely, for example when a full frame lens is first > measured with smaller sensor and later on full frame camera). Good point. > So I think that UFRaw should use either one set of parameters or another, but > don't combine values from both. And the set in ID file is incomplete. When LensfunAuto is true, UFRaw could alway read the parameters from LensDB. This is what I do for configuration files. For ID files I usually aim at reproducing the original output, so it is not optimal. If UFRaw does use the parameters from the ID file, it needs to treat them as manually set, at least if they are different from the LensDB params. This is tricky and a bit ugly. Udi ------------------------------------------------------------------------------ BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The must-attend event for mobile developers. Connect with experts. Get tools for creating Super Apps. See the latest technologies. Sessions, hands-on labs, demos & much more. Register early & save! http://p.sf.net/sfu/rim-blackberry-1 _______________________________________________ ufraw-devel mailing list ufraw-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ufraw-devel
