JW> have the same string applied to the mUniversality agent selector in the bundled portlets which would be a good thing
Probably would be a better thing for the portal to signal to the portlets the mobile-ness of the user agent rather than duplicate that configuration out into the portlets. :) Backlogged https://issues.jasig.org/browse/UP-4284 to tease this out of pom.xml and authoritatively into portal.properties. Andrew On Tue, Nov 4, 2014 at 9:23 AM, James Wennmacher <[email protected]> wrote: > I think it allows maven filtering into PAGSGroupStoreConfig.xml (and of > course into portal.properties) to have a single definition, though the > regex tester could be replaced with a specialized class to remove it from > the xml file. Looks like it is also in userContext.xml though that one can > use the portal.properties value instead of maven filtering. The value in > portal.properties is derived from the value in the pom.xml so I'm not sure > what you mean when you say you tripped over it. As far as I can tell right > now there is only one definition (in pom.xml). > > As an aside being in the pom.xml I think it could allow, using maven > overlays, to have the same string applied to the mUniversality agent > selector in the bundled portlets which would be a good thing, though it > does not as of this moment. > > James Wennmacher - Unicon > 480.558.2420 > > > On 11/04/2014 07:05 AM, Andrew Petro wrote: > >> Hi, >> >> Anyone remember why >> >> <mobile.user.agent.regex>(.*iPhone.*)...</mobile.user.agent.regex> >> >> ( source code line: http://goo.gl/gtL8kA ) >> >> is in pom.xml instead of in portal.properties? >> >> Tripped over this just now and looking to proffer a PR offering a >> breadcrumb to the next poor fellow to trip over it. >> >> Andrew >> >> -- >> >> You are currently subscribed to [email protected] as: >> [email protected] >> To unsubscribe, change settings or access archives, see >> http://www.ja-sig.org/wiki/display/JSG/uportal-dev >> > > > -- > You are currently subscribed to [email protected] as: > [email protected] > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/uportal-dev > -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/uportal-dev
