GitHub user pitrou added a comment to the discussion: Offering to do an experiment if someone helps: Reducing `shared_ptr` refcount traffic, such as pass-by-value?
Hi! It's great to see you interested in Arrow. > For example (these are all either called in loops, or appear to be liable to > be frequently used including potentially in hot code though I don’t know the > code enough to be sure): These examples look either not hot, or they are batched computation functions where the shared_ptr copy cost would probably be dominated by the overall computation cost (depending on the input Array / RecordBatch size). > If I created a PR that proposes changing a bunch of pass-by-value cases to > eliminate needless refcount inc/dec, would someone here who is able to run > some performance tests be interested in verifying the proposed changes and > how much (if at all) they might help performance? We have a benchmarking suite so ideally we can do that, but I think we ran out of AWS credits. 🫤 (@rok is that right?) That said, even without any significant perf improvements, small harmless code-level improvements can go in anyway. GitHub link: https://github.com/apache/arrow/discussions/51147#discussioncomment-18263793 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected]
