I think the pertinent question is whether there are interesting cases where
the BucketingSink is still a better choice. One case I'm not sure about is
the situation described in docs for the StreamingFileSink under Important
Note 2 [1]:
... upon normal termination of a job, the last in-progress files will
not be transitioned to the “finished” state.
I know this confuses and frustrates users, but I don't know if the
BucketingSink has any advantages in this regard.
[1]
https://ci.apache.org/projects/flink/flink-docs-release-1.11/dev/connectors/streamfile_sink.html#important-considerations
On Tue, Oct 13, 2020 at 11:06 AM Konstantin Knauf <kna...@apache.org> wrote:
> Given that it has been deprecated for three releases now, I am +1 to
> dropping it.
>
> On Mon, Oct 12, 2020 at 9:38 PM Chesnay Schepler <ches...@apache.org>
> wrote:
>
>> Is there a way for us to change the module (in a reasonable way) that
>> would allow users to continue using it?
>> Is it an API problem, or one of semantics?
>>
>> On 10/12/2020 4:57 PM, Kostas Kloudas wrote:
>> > Hi Chesnay,
>> >
>> > Unfortunately not from what I can see in the code.
>> > This is the reason why I am opening a discussion. I think that if we
>> > supported backwards compatibility, this would have been an easier
>> > process.
>> >
>> > Kostas
>> >
>> > On Mon, Oct 12, 2020 at 4:32 PM Chesnay Schepler <ches...@apache.org>
>> wrote:
>> >> Are older versions of the module compatible with 1.12+?
>> >>
>> >> On 10/12/2020 4:30 PM, Kostas Kloudas wrote:
>> >>> Hi all,
>> >>>
>> >>> As the title suggests, this thread is to discuss the removal of the
>> >>> flink-connector-filesystem module which contains (only) the deprecated
>> >>> BucketingSink. The BucketingSin is deprecated since FLINK 1.9 [1] in
>> >>> favor of the relatively recently introduced StreamingFileSink.
>> >>>
>> >>> For the sake of a clean and more manageable codebase, I propose to
>> >>> remove this module for release-1.12, but of course we should see first
>> >>> if there are any usecases that depend on it.
>> >>>
>> >>> Let's have a fruitful discussion.
>> >>>
>> >>> Cheers,
>> >>> Kostas
>> >>>
>> >>> [1] https://issues.apache.org/jira/browse/FLINK-13396
>> >>>
>>
>>
>
> --
>
> Konstantin Knauf
>
> https://twitter.com/snntrable
>
> https://github.com/knaufk
>
