To me, the commit looks correct: The factory PID is what should be used to create the factory configuration. Without having looked deeper in the code, this looks like the caller of that method confuses PID and Factory PID. But there must be two places where this is called, because the configuration via File wasn't affected.
Regards, Benjamin -----Original Message----- From: Jean-Baptiste Onofré [mailto:[email protected]] Sent: Mittwoch, 2. Juli 2014 17:10 To: [email protected] Subject: Re: Problems With Factory Configurations In Karaf 3.0.1 Hmmm, not 100% sure, let me review it again. Regards JB On 07/02/2014 05:06 PM, Jean-Baptiste Onofré wrote: > Hi Gareth, > > I agree (my bad). > > Let me reopen and revert. > > Regards > JB > > On 07/02/2014 05:01 PM, Gareth wrote: >> Hello Benjamin, >> >> Thanks for doing the testing! I think I can see the relevant commit: >> >> https://github.com/apache/karaf/commit/b398c7690a09b02ad0f900fa4d6f51 >> 308f5970aa >> >> >> >> features/core/src/main/java/org/apache/karaf/features/internal/Featur >> esServiceImpl.java >> >> >> protected Configuration createConfiguration(ConfigurationAdmin >> configurationAdmin, >> String pid, String >> factoryPid) throws IOException, InvalidSyntaxException { >> if (factoryPid != null) { >> - return configurationAdmin.createFactoryConfiguration(pid, >> null); >> + return >> configurationAdmin.createFactoryConfiguration(factoryPid, null); >> } else { >> return configurationAdmin.getConfiguration(pid, null); >> } >> >> If I understand the code in this file correctly, if I put this in my >> feature >> file: >> >> <config name="foo.bar-unencrypted"> >> >> the pid variable here is "foo.bar" and the factoryPid variable is >> "unencrypted". Perhaps this change should be reverted? >> >> thanks, >> Gareth >> >> >> >> >> >> -- >> View this message in context: >> http://karaf.922171.n3.nabble.com/Problems-With-Factory-Configuration >> s-In-Karaf-3-0-1-tp4033921p4033949.html >> >> Sent from the Karaf - User mailing list archive at Nabble.com. >> > -- Jean-Baptiste Onofré [email protected] http://blog.nanthrax.net Talend - http://www.talend.com
