-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Ok
Pranay Pandey sent the following on 3/20/2009 4:03 AM: > Code has been cleaned up by Hans in rev. 756412 > No issues now. > > Regards > -- > Pranay Pandey > > On Mar 20, 2009, at 4:29 PM, Pranay Pandey wrote: > >> Thanks BJ, >> This was being used to access SkillType BJ and thats seed data. >> BTW unused code has been committed by Hans in rev. 756412 >> >> >> Thanks & Regards >> -- >> Pranay Pandey >> On Mar 20, 2009, at 4:25 PM, BJ Freeman wrote: >> > If you give me links to your other ones will be glad to check. > my guess is the data is not there for findlist > > Divesh Dutta sent the following on 3/20/2009 3:39 AM: >>>>> Hello all, >>>>> Major concern was that findList method should not be used >>>>> in .ftl files. But it is used in EditTimeEntry.ftl, edittasklist.ftl >>>>> and in editProjectskills.ftl. And following .ftl files are not used in >>>>> any where. So I think this should be cleaned up if it is not of use: >>>>> 1) EditTimeEntry.ftl >>>>> 2) edittasklist.ftl >>>>> >>>>> And if EditProjectSkills request is not used in any of the link then >>>>> entries related to this should also be cleaned up from >>>>> controller.xml of >>>>> projectmgr. >>>>> >>>>> Thanks >>>>> -Divesh >>>>> >>>>> BJ Freeman wrote: >>>>> hans I just ran this against the trunk and it is there. >>>>> >>>>> >>>>> Pranay: >>>>> I looked at the log and see no errors. >>>>> >>>>> Hans Bakker sent the following on 3/20/2009 3:09 AM: >>>>> >>>>>>>> But you did not tell where this was used, apparently not? >>>>>>>> >>>>>>>> The simplest solution is to simply delete these files because >>>>>>>> they are >>>>>>>> not used....they are left overs from a previous version of the >>>>>>>> project >>>>>>>> manager >>>>>>>> >>>>>>>> Regards, >>>>>>>> Hans >>>>>>>> >>>>>>>> On Fri, 2009-03-20 at 04:58 -0500, Pranay Pandey wrote: >>>>>>>> >>>>>>>>> Thanks Hans for looking into it. >>>>>>>>> >>>>>>>>> Let me explain whats happening. >>>>>>>>> Url which you have given is: >>>>>>>>> https://localhost:8443/projectmgr/control/EditTaskSkills?workEffortId=9103 >>>>>>>>> >>>>>>>>> >>>>>>>>> Your url points to the view TaskScreens.xml#EditTaskSkills in which >>>>>>>>> ftl has not been used its using form widget. >>>>>>>>> >>>>>>>>> and In my url I am referring to following request and view: >>>>>>>>> >>>>>>>>> <request-map uri="EditProjectSkills"> >>>>>>>>> <security https="true" auth="true"/> >>>>>>>>> <response name="success" type="view" value="EditProjectSkills"/> >>>>>>>>> </request-map> >>>>>>>>> >>>>>>>>> <view-map name="EditProjectSkills" type="screen" >>>>>>>>> page="component://projectmgr/widget/ProjectScreens.xml#EditProjectSkills"/> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> Which referes to an ftl by name editProjectskills.ftl. In this file >>>>>>>>> findList has been used and thats not working. >>>>>>>>> >>>>>>>>> Thanks & Regards >>>>>>>>> -- >>>>>>>>> Pranay Pandey >>>>>>>>> >>>>>>>>> ----- "Hans Bakker" <[email protected]> wrote: >>>>>>>>> >>>>>>>>> >>>>>>>>>> From: "Hans Bakker" <[email protected]> >>>>>>>>>> To: [email protected] >>>>>>>>>> Sent: Friday, March 20, 2009 3:03:35 PM GMT +05:30 Chennai, >>>>>>>>>> Kolkata, Mumbai, New Delhi >>>>>>>>>> Subject: Re: delegator.finlist method doesn't work in ftl >>>>>>>>>> >>>>>>>>>> Hi Pranay, >>>>>>>>>> this is very interesting because i cannot find this url on any >>>>>>>>>> link >>>>>>>>>> in >>>>>>>>>> the system....further, skills are defined on the task level for >>>>>>>>>> example: >>>>>>>>>> https://localhost:8443/projectmgr/control/EditTaskSkills?workEffortId=9103 >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> and there it is working fine..... >>>>>>>>>> >>>>>>>>>> so i am very puzzled how you get to this link using the >>>>>>>>>> menus...... >>>>>>>>>> In the trunk version there are no "projectskills" >>>>>>>>>> >>>>>>>>>> Regards, >>>>>>>>>> Hans >>>>>>>>>> >>>>>>>>>> On Fri, 2009-03-20 at 04:03 -0500, Pranay Pandey wrote: >>>>>>>>>> >>>>>>>>>>> Thanks Hans, >>>>>>>>>>> >>>>>>>>>>> Here is the url: >>>>>>>>>>> >>>>>>>>>> https://localhost:8443/projectmgr/control/EditProjectSkills >>>>>>>>>> >>>>>>>>>>> Thanks & Regards >>>>>>>>>>> -- >>>>>>>>>>> Pranay Pandey >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> ----- "Hans Bakker" <[email protected]> wrote: >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> From: "Hans Bakker" <[email protected]> >>>>>>>>>>>> To: [email protected] >>>>>>>>>>>> Sent: Friday, March 20, 2009 2:19:02 PM GMT +05:30 Chennai, >>>>>>>>>>>> >>>>>>>>>> Kolkata, Mumbai, New Delhi >>>>>>>>>> >>>>>>>>>>>> Subject: Re: delegator.finlist method doesn't work in ftl >>>>>>>>>>>> >>>>>>>>>>>> skill type within project manager is working fine here as i can >>>>>>>>>>>> see... >>>>>>>>>>>> please give me the url and i will have a look.... >>>>>>>>>>>> >>>>>>>>>>>> On Fri, 2009-03-20 at 03:32 -0500, Pranay Pandey wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Hello David, >>>>>>>>>>>>> >>>>>>>>>>>>> Arun is referring to the existing ftl which is in OFBiz trunk, >>>>>>>>>>>>> >>>>>>>>>> so >>>>>>>>>> >>>>>>>>>>>> IMO we should improve the code for those screens in which this >>>>>>>>>>>> >>>>>>>>>> has >>>>>>>>>> >>>>>>>>>>>> been used in ftls. There are 3 ftls from projectmgr which uses >>>>>>>>>>>> >>>>>>>>>> this. >>>>>>>>>> >>>>>>>>>>>>> Thanks & Regards >>>>>>>>>>>>> -- >>>>>>>>>>>>> Pranay Pandey >>>>>>>>>>>>> >>>>>>>>>>>>> ----- "David E Jones" <[email protected]> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>>> From: "David E Jones" <[email protected]> >>>>>>>>>>>>>> To: [email protected] >>>>>>>>>>>>>> Sent: Friday, March 20, 2009 1:39:47 PM GMT +05:30 Chennai, >>>>>>>>>>>>>> >>>>>>>>>>>> Kolkata, Mumbai, New Delhi >>>>>>>>>>>> >>>>>>>>>>>>>> Subject: Re: delegator.finlist method doesn't work in ftl >>>>>>>>>>>>>> >>>>>>>>>>>>>> Why are you calling it in the FTL file and not in an action in >>>>>>>>>>>>>> >>>>>>>>>> the >>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>>> screen definition (the normal place to do data preparation, >>>>>>>>>>>>>> >>>>>>>>>> FTL is >>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>>> just for layout of prepared data). >>>>>>>>>>>>>> >>>>>>>>>>>>>> -David >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Mar 20, 2009, at 12:17 AM, Arun Patidar wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>>> Hello all, >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> When I try to access this request >>>>>>>>>>>>>>> >>>>>>>>>>>>>> https://localhost:8443/projectmgr/control/EditProjectSkills >>>>>>>>>>>>>> >>>>>>>>>>>>>>> , getting error. >>>>>>>>>>>>>>> IMO this is because we can not use delegator.findList method >>>>>>>>>>>>>>> >>>>>>>>>> in >>>>>>>>>> >>>>>>>>>>>>>> ftl. >>>>>>>>>>>>>> >>>>>>>>>>>>>>> This has been used like this: <#assign skillTypes = >>>>>>>>>>>>>>> delegator.findList("SkillType", null, null, null, null, >>>>>>>>>>>>>>> >>>>>>>>>> false)> >>>>>>>>>> >>>>>>>>>>>>>>> If I use it like <#assign skillTypes = >>>>>>>>>>>>>>> delegator.findList("SkillType", NULL, NULL, NULL, NULL, >>>>>>>>>>>>>>> >>>>>>>>>> false)> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>>>> then it works fine. >>>>>>>>>>>>>>> Do we need to change something at framework level. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Here is the log: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Method public java.util.List org .ofbiz .entity >>>>>>>>>>>>>>> .GenericDelegator .findList (java .lang .String ,org .ofbiz >>>>>>>>>>>>>>> .entity .condition .EntityCondition ,java .util >>>>>>>>>>>>>>> >>>>>>>>>> .Set,java.util.List,org.ofbiz.entity.util.EntityFindOptions,boolean) >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>>> throws org.ofbiz.entity.GenericEntityException threw an >>>>>>>>>>>>>>> >>>>>>>>>>>> exception >>>>>>>>>>>>>>> when invoked on org.ofbiz.entity.genericdelega...@10b51f4 >>>>>>>>>>>>>>> >>>>>>>>>> The >>>>>>>>>>>>>>> problematic instruction: ---------- ==> assignment: >>>>>>>>>>>>>>> skillTypes=delegator.findList("SkillType", null, null, >>>>>>>>>>>>>>> >>>>>>>>>> null, >>>>>>>>>> >>>>>>>>>>>> null, >>>>>>>>>>>>>>> false) [on line 36, column 13 in >>>>>>>>>>>>>>> >>>>>>>>>> component://projectmgr/webapp/ >>>>>>>>>> >>>>>>>>>>>>>>> projectmgr/project/editProjectskills.ftl] ---------- Java >>>>>>>>>>>>>>> >>>>>>>>>>>> backtrace >>>>>>>>>>>>>>> for programmers: ---------- >>>>>>>>>>>>>>> freemarker.template.TemplateModelException: Method public >>>>>>>>>>>>>>> java.util.List org .ofbiz .entity .GenericDelegator >>>>>>>>>>>>>>> .findList >>>>>>>>>>>>>>> (java .lang .String ,org .ofbiz .entity .condition >>>>>>>>>>>>>>> .EntityCondition ,java .util >>>>>>>>>>>>>>> >>>>>>>>>> .Set,java.util.List,org.ofbiz.entity.util.EntityFindOptions,boolean) >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>>> throws org.ofbiz.entity.GenericEntityException threw an >>>>>>>>>>>>>>> >>>>>>>>>>>> exception >>>>>>>>>>>>>>> when invoked on org.ofbiz.entity.genericdelega...@10b51f4 at >>>>>>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java: >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>>>>>> 130) at >>>>>>>>>>>>>>> >>>>>>>>>>>> freemarker.core.MethodCall._getAsTemplateModel(MethodCall.java:93) >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>>>> at >>>>>>>>>>>>>>> >>>>>>>>>>>> freemarker.core.Expression.getAsTemplateModel(Expression.java:89) >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>>> at freemarker.core.Assignment.accept(Assignment.java:90) at >>>>>>>>>>>>>>> freemarker.core.Environment.visit(Environment.java:209) at >>>>>>>>>>>>>>> freemarker.core.MixedContent.accept(MixedContent.java:92) at >>>>>>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>>>>>> freemarker.core.Environment.visit(Environment.java:209) at >>>>>>>>>>>>>>> freemarker.core.Environment.process(Environment.java:189) >>>>>>>>>>>>>>> >>>>>>>>>> at >>>>>>>>>> >>>>>>>>>>>>>>> Please correct me if I am wrong. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Thanks & Regards >>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>> Arun Patidar >>>>>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> Antwebsystems.com: Quality OFBiz services for competitive rates >>>>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Antwebsystems.com: Quality OFBiz services for competitive rates >>>>>>>>>> >> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFJw3mjrP3NbaWWqE4RAlL/AJ9GHb/Xm3IJBjEEehBmD3ovgIIlZwCgq/Rq 4/0VaC5EUOqFKRAacmrtT2k= =jn6b -----END PGP SIGNATURE-----
