Hi ,
After seeking offbiz code , I found that there are lots of small work required in making offbiz code as standard code. Like 1) There are so many hard cocded string at every place. Like "user-login" used as a string every place , Can we moved it to a constant file and refer that string from constant file. this will be a best coding practice. 2) In ConfigXMLReader.ControllerConfig There are some variable defined which are public. * public* *Map* configMap = FastMap.*newInstance*(); *public* *Map* handlerMap = FastMap.*newInstance*(); *public* *Map* requestMap = FastMap.*newInstance*(); *public* *Map* viewMap = FastMap.*newInstance*(); *public* String defaultRequest = *null*; I found some of these ,there meight be a possiblity offbiz have more issue like that. Can we fix this type of issue. I know these are the small issue , but as per the coding standard and practice wise If we follow coding standard define by Java , We will make offbiz as a great product , which will fullfill all aspect of funcanality and technically. I am refereing to relese 4.0 . If these issue are fixed in any other branch , Please let me know If I am not aware of that things. -- Regards, Sumit Solution Architect Pune skypee: deepaka231 +91-9221182885
