take a look at release 9.04 just released. and if you look you will find that most if not all use the labels to internationalization's.
as far as things like public declarations. this is a community project, it is open source after all. the as many lines of code there are, it takes a lot to review and fix. Welcome and contribute. http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Documentation+Index particularly http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices Ambient Solution sent the following on 5/6/2009 7:21 PM: > Hi , > > > > After seeking offbiz code , I found that there are lots of small work > required in making offbiz code as standard code. Like > > 1) There are so many hard cocded string at every place. Like "user-login" > used as a string every place , Can we moved it to a constant file and refer > that string from constant file. this will be a best coding practice. > 2) In ConfigXMLReader.ControllerConfig > > There are some variable defined which are public. > > * > > public* *Map* configMap = FastMap.*newInstance*(); > > *public* *Map* handlerMap = FastMap.*newInstance*(); > > *public* *Map* requestMap = FastMap.*newInstance*(); > > *public* *Map* viewMap = FastMap.*newInstance*(); > > *public* String defaultRequest = *null*; > I found some of these ,there meight be a possiblity offbiz have more > issue like that. > > Can we fix this type of issue. I know these are the small issue , but as > per the coding standard and practice wise If we follow coding standard > define by Java , We will make offbiz as a great product , which will > fullfill all aspect of funcanality and technically. > > I am refereing to relese 4.0 . If these issue are fixed in any other > branch , Please let me know If I am not aware of that things. > > -- BJ Freeman http://www.businessesnetwork.com/automation http://bjfreeman.elance.com http://www.linkedin.com/profile?viewProfile=&key=1237480&locale=en_US&trk=tab_pro Systems Integrator.
