Hi Mayank, It's a good initiative. As some of the numeric data price, quantity is generally right-aligned. +1 on creating generic names of classes and moving ahead.
I think the "align" attribute is used at some of the tables. As per HTML5, 'align' attribute is not supported, so code cleaning will also be required there. Regards, Jagpreet Kaur Khanuja On Mon, Aug 28, 2017 at 12:21 PM, Mayank Lambhate < [email protected]> wrote: > Thank you all for your suggestions, > > If everyone agrees, we can move forward by creating generic names of the > CSS classes as provided by bootstrap. > > > Thanks and Regards > > -- > > *Mayank Lambhate* | Enterprise Software Engineer > HotWax Systems <http://www.hotwaxsystems.com/> > > > On Mon, Aug 28, 2017 at 11:55 AM, Rishi Solanki <[email protected]> > wrote: > > > Nitish, > > I think what Taher is suggesting, to use the naming conventions used in > > bootstrap instead of try to form dictionary of our own. I also agree with > > him, to use a standard practice for naming the classes. > > > > +1 Mayank for the idea. > > > > Rishi Solanki > > Sr Manager, Enterprise Software Development > > HotWax Systems Pvt. Ltd. > > Direct: +91-9893287847 > > http://www.hotwaxsystems.com > > www.hotwax.co > > > > On Mon, Aug 28, 2017 at 11:40 AM, Nitish Mishra < > > [email protected]> wrote: > > > > > Hello Taher, > > > > > > Thanks for your suggestion. > > > > > > Currently, we don't have bootstrap integration in OFBiz. So, if we are > > > planning to give bootstrap support, then there would be no need to > create > > > our own CSS dictionary. > > > > > > Please let us know if you have any plans for the same. > > > > > > On Sun, Aug 27, 2017 at 12:53 AM, Jacques Le Roux < > > > [email protected]> wrote: > > > > > > > Great idea, thanks Taher! > > > > > > > > Jacques > > > > > > > > > > > > > > > > Le 26/08/2017 à 21:19, Taher Alkhateeb a écrit : > > > > > > > >> If I may suggest, I think we should go with something established > and > > > >> not come up with our own CSS dictionary. So for example, we can > > > >> utilize pre-existing definitions from bootstrap [1] > > > >> > > > >> [1] https://getbootstrap.com/docs/3.3/css/#tables > > > >> > > > >> On Sat, Aug 26, 2017 at 3:27 PM, Mayank Lambhate > > > >> <[email protected]> wrote: > > > >> > > > >>> Hello All, > > > >>> > > > >>> The tables used in OFBiz currently don`t have any standard for > > defining > > > >>> the > > > >>> alignment of data inside the tables. IMO, following are the points > > > >>> relevant > > > >>> to alignment of data in tables - > > > >>> > > > >>> 1. Numeric data (Right Aligned) > > > >>> 2. Non-Numeric (Left Aligned) > > > >>> 3. Table headers to be aligned with the data. > > > >>> > > > >>> Also, the names of classes used for aligning data are a bit > > confusing. > > > We > > > >>> can come up with more generic names of the classes, also we can > > define > > > >>> certain classes that could be specific to the alignment of data > > inside > > > >>> tables. > > > >>> > > > >>> Please let me know what you think about this. > > > >>> > > > >>> > > > >>> Thanks and Regards > > > >>> > > > >>> *Mayank Lambhate* | Enterprise Software Engineer > > > >>> HotWax Systems <http://www.hotwaxsystems.com/> > > > >>> > > > >> > > > > > > > > > > > > > -- > > > > > > > > > *Thanks and Regards* > > > > > > *Nitish Mishra* | Enterprise Software Engineer > > > HotWax Systems <http://www.hotwaxsystems.com/> > > > > > >
