On 04/06/2012 10:16 AM, Alan Coopersmith wrote:
On 04/ 6/12 09:43 AM, Rich Burridge wrote:
Hi,
Could I please get a code review for the changes for:
7159589 Adjust foomatic/fppd action to remove gzip -rf usage
http://monaco.us.oracle.com/detail.jsf?cr=7159589
Webrev is at:
http://jurassic.us.oracle.com/~richb/7159589-v1/
Do you need to explicitly cd to the directory first?
Apparently, no I don't.
Can't you just do:
/usr/bin/find $(SOURCE_DIR)/share/ppd -name "*.ppd" -exec gzip {} +
Nice. I've adjusted the command to what you really meant to type :-)
(isn't find command line argument syntax wonderful!), and there
is a new webrev at:
http://jurassic.us.oracle.com/~richb/7159589-v2/
And of course, there's also the question of if it makes sense to package the
files gzip'ed given current disk sizes and zfs filesystem-level support for
compression. In X, we stopped gzip'ing fonts because it wasn't saving enough
space to be worthwhile in most cases, and was instead wasting more space on the
live media& filesystem, since gzip shrinks files less than the other
compression methods used in those, and files that are already gzipped can't be
compressed as well as the raw files.
Looking at the output of:
find /usr/share/ppd -name '*.gz' -exec gzip -l {} + | less
it appears mostly you're shrinking files from 20k down to 3-4k, which is hardly
a big win on a terabyte hard disk.
Agreed, but this is beyond the scope of this bug.
I just wanted to change the one line (okay, it's two with the Copyright
line change as well), rather than 4172 lines in the .p5m file and
presumably some other code somewhere else that unpacks these .gz
files as needed.
Thanks.
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
