On 04/ 6/12 10:43 AM, Rich Burridge wrote:
> On 04/06/2012 10:16 AM, Alan Coopersmith wrote:
>> On 04/ 6/12 09:43 AM, Rich Burridge wrote:
>>> Hi,
>>>
>>> Could I please get a code review for the changes for:
>>>
>>> 7159589 Adjust foomatic/fppd action to remove gzip -rf usage
>>> http://monaco.us.oracle.com/detail.jsf?cr=7159589
>>>
>>>
>>> Webrev is at:
>>>
>>> http://jurassic.us.oracle.com/~richb/7159589-v1/
>> Do you need to explicitly cd to the directory first?
>
> Apparently, no I don't.
>
>> Can't you just do:
>> /usr/bin/find $(SOURCE_DIR)/share/ppd -name "*.ppd" -exec gzip {} +
>
> Nice. I've adjusted the command to what you really meant to type :-)
> (isn't find command line argument syntax wonderful!), and there
> is a new webrev at:
>
> http://jurassic.us.oracle.com/~richb/7159589-v2/
Actually, I really did mean "+", not ";" - as documented in the find man page:
If the
last argument to -exec is {} and you
specify + rather than the semicolon (;),
the command is invoked fewer times, with
{} replaced by groups of pathnames.
And, yes, find syntax is amazingly baroque, isn't it?
--
-Alan Coopersmith- [email protected]
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
