On 04/23/2012 03:26 PM, Tim Foster wrote:
I've got a small changeset here that adds the Apache mod_wsgi module
to userland. I'm hoping to squeeze it into b15 if at all possible.
https://cr.opensolaris.org/action/browse/pkg/timf/userland-mod_wsgi/userland-mod_wsgi-webrev/
Thanks to Danek for the initial work on getting mod_wsgi
userland-ready, and Rich for sponsoring the ARC case :-)
Comments would be most welcome.
.../components/apache2-modules/mod_wsgi/Makefile:
* line 36ish: You need to include a COMPONENT_PROJECT_URL line.
From looking at the PSARC case, I think that should be:
COMPONENT_PROJECT_URL= http://code.google.com/p/modwsgi
* line 37: I don't think you need to define PYTHON_VERSIONS to this.
That's the default.
In fact, do you really need any of lines 48-63? Shouldn't this be
all automatically picked up from setup.py.mk?
* line 72, 78: that's one way of doing it. Personally I would have
just done this via a COMPONENT_POST_INSTALL_ACTION. For example,
see .../components/pylint/Makefile
.../components/apache2-modules/mod_wsgi/mod_wsgi-26.p5m
.../components/apache2-modules/mod_wsgi/mod_wsgi-27.p5m
.../components/apache2-modules/mod_wsgi/mod_wsgi.p5m
* line 33ish: if you add in the COMPONENT_PROJECT_URL to the Makefile, this
now becomes:
set name=info.upstream-url value=$(COMPONENT_PROJECT_URL)
.../components/apache2-modules/mod_wsgi/patches/srcdir.patch
Note that unlike some other consolidations, what you have in the manifest
file(s) doesn't have to be an exact match what what you have installed. In
other words, it's perfectly acceptable to build/install things like .la
files,
and then just not include them in the .p5m files.
So, do you really need this patch? Maybe just a cut down version of it...
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
