On 04/24/12 11:01 AM, Rich Burridge wrote:
On 04/23/2012 03:26 PM, Tim Foster wrote:
https://cr.opensolaris.org/action/browse/pkg/timf/userland-mod_wsgi/userland-mod_wsgi-webrev/
.../components/apache2-modules/mod_wsgi/Makefile:
* line 36ish: You need to include a COMPONENT_PROJECT_URL line.
From looking at the PSARC case, I think that should be:
COMPONENT_PROJECT_URL= http://code.google.com/p/modwsgi
Cool, fixed that - thanks.
* line 37: I don't think you need to define PYTHON_VERSIONS to this.
That's the default.
You're right, I can remove this.
In fact, do you really need any of lines 48-63? Shouldn't this be
all automatically picked up from setup.py.mk?
Right, we can't include setup.py.mk since mod_wsgi doesn't use setup.py,
so we get an error,
/usr/bin/python2.6: can't open file './setup.py': [Errno 2] No such file
or directory
* line 72, 78: that's one way of doing it. Personally I would have
just done this via a COMPONENT_POST_INSTALL_ACTION. For example,
see .../components/pylint/Makefile
Ah thanks, I've fixed that too.
.../components/apache2-modules/mod_wsgi/mod_wsgi-26.p5m
.../components/apache2-modules/mod_wsgi/mod_wsgi-27.p5m
.../components/apache2-modules/mod_wsgi/mod_wsgi.p5m
* line 33ish: if you add in the COMPONENT_PROJECT_URL to the Makefile, this
now becomes:
set name=info.upstream-url value=$(COMPONENT_PROJECT_URL)
Yep, that's nicer - I've done it this way now.
.../components/apache2-modules/mod_wsgi/patches/srcdir.patch
Note that unlike some other consolidations, what you have in the manifest
file(s) doesn't have to be an exact match what what you have installed. In
other words, it's perfectly acceptable to build/install things like .la
files,
and then just not include them in the .p5m files.
Sure.
So, do you really need this patch? Maybe just a cut down version of it...
Well, this patch is really here to allow us to rename the module during
the build, as opposed to having it always produce "mod_wsgi.so", so I'm
inclined to leave it as is.
I've got an updated webrev at:
https://cr.opensolaris.org/action/browse/pkg/timf/userland-mod_wsgi-v1
I'll happily supply an incremental webrev if anyone would like to see it.
cheers,
tim
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
