On 04/23/2012 05:49 PM, Tim Foster wrote:
...
In fact, do you really need any of lines 48-63? Shouldn't this be
all automatically picked up from setup.py.mk?
Right, we can't include setup.py.mk since mod_wsgi doesn't use
setup.py, so we get an error,
/usr/bin/python2.6: can't open file './setup.py': [Errno 2] No such
file or directory
Fair enough. As suggested on IRC, I'd like to see a low-level RFE
submitted, to move those
lines out of the setup.py.mk file into a separate .mk file, that gets
included by setup.py.mk
or could just be directly included in a Makefile such as yours.
...
Well, this patch is really here to allow us to rename the module
during the build, as opposed to having it always produce
"mod_wsgi.so", so I'm inclined to leave it as is.
Okay. I suspect you could also do this with a COMPONENT_POST_BUILD_ACTION
where it just cp's or mv's the generic mod_wsgi.so to
mod_wsgi-$(PYTHON_VERSION).so
That might be simpler. You wouldn't have to keep trying to keep your patch
in sync, and/or get it accepted upstream.
I've got an updated webrev at:
https://cr.opensolaris.org/action/browse/pkg/timf/userland-mod_wsgi-v1
One thing I totally forgot to mention in the last review is that legal
would like us to
put the component name, version number and Third Party tracking Number
at the beginning of the license file. Looks like your TPNO is #7687, so
that means
you are going to have to copy the LICENSE file out of the sources, "hg
add" it
to the workspace and prepend:
----------------
- mod_wsgi 3.3 -
----------------
Oracle Internal Tracking Number 7687
to the front of the file and then adjust the license line in the two
.p5m files
accordingly.
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
