That works fine on my machine. Thank You.
Dave Brett Porter <[EMAIL PROTECTED]> wrote on 12/05/2004 16:58:16: > I've committed the following: > -if exist %JAVA_HOME%\nul goto chkMHome > +if exist "%JAVA_HOME%\bin\java.exe" goto chkMHome > > Can you make that change and check that it works under your installation > with spaces? > Thanks, > Brett > > -----Original Message----- > > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > > Sent: Wednesday, 12 May 2004 1:46 PM > > To: Maven Users List > > Subject: RE: RC2 Windows - Maven.bat does not allow spaces in > > JAVA_HOME > > > > > > Unfortunately the \nul and the quotes appear to be mutually > > exclusive (at > > least on Win2000). > > I have tried: > > if exist "%JAVA_HOME%"\nul goto chkMHome > > and > > if exist "%JAVA_HOME%\nul" goto chkMHome > > > > But for both tests get > > ERROR: JAVA_HOME is set to an invalid directory. > > > > Might have to have something like: > > > > if "%OS%"=="Windows_NT" if exist "%JAVA_HOME%" goto chkMHome > > if NOT "%OS%"=="Windows_NT" if exist "%JAVA_HOME%\nul" goto chkMHome > > > > Will need to check this works OK on win98 however. > > By the way, this is the only place that the \nul is used. > > > > Cheers Dave > > > > > > Brett Porter <[EMAIL PROTECTED]> wrote on 12/05/2004 15:16:38: > > > > > I think the \nul is still necessary for Windows 98. > > > > > If this is the only location in the file, I can test this > > quickly on > > > my > > work > > > machine. > > > > > Thanks, > > > Brett > > > > > > -----Original Message----- > > > > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > > > > Sent: Wednesday, 12 May 2004 1:14 PM > > > > To: Maven Users List > > > > Subject: RE: RC2 Windows - Maven.bat does not allow spaces in > > > > JAVA_HOME > > > > > > > > > > > > Brett, > > > > > > > > I do not have CVS access because of our firewall (will be > > sorted out > > > > next week). I have just copy and pasted revision 1.40 from Web > > > > Access CVS into > > > > WebSphere Studio done the change and created a unified patch. > > > > As the paths > > > > and revisions were then not right I have updated them by hand > > > > (hopefully > > > > its right but I am not experienced with patches). > > > > > > > > I have tested the updated batch file on Windows 2000 > > service pack 4. > > > > > > > > Cheers Dave > > > > > > > > Index: maven.bat > > > > > > =================================================================== > > > > RCS file: /home/cvspublic/maven/src/bin/maven.bat,v > > > > retrieving revision 1.40 > > > > diff -u -r1.40 maven.bat > > > > --- maven.bat 2004/03/23 02:18:17 1.40 > > > > +++ maven.bat 2004/05/12 14:45:36 > > > > @@ -53,7 +53,7 @@ > > > > goto end > > > > > > > > :OkJHome > > > > -if exist %JAVA_HOME%\nul goto chkMHome > > > > +if exist "%JAVA_HOME%" goto chkMHome > > > > > > > > echo. > > > > echo ERROR: JAVA_HOME is set to an invalid directory. > > > > > > > > > > > > > > > > Brett Porter <[EMAIL PROTECTED]> wrote on 12/05/2004 > > > > 12:12:19: > > > > > > > > > You're right. The fix was for JAVA_HOME. > > > > > > > > > Can you submit a tested patch for JAVA_HOME? > > > > > > > > > - Brett > > > > > > > > > > -----Original Message----- > > > > > > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > > > > > > Sent: Wednesday, 12 May 2004 9:37 AM > > > > > > To: Maven Users List > > > > > > Subject: RE: RC2 Windows - Maven.bat does not allow spaces in > > > > > > JAVA_HOME > > > > > > > > > > > > > > > > > > Brett, > > > > > > > > > > > > I am a newbie at this, but I checked the Web Access > > CVS before I > > > > > > posted. I navigated to maven/src/bin/maven.bat and the latest > > > > > > revision was 1.40 which still had the fault. If it is > > > > already fixed > > > > > > in CVS how do I see the > > > > > > latest revision using the Web Access? > > > > > > > > > > > > Cheers Dave > > > > > > > > > > > > Brett Porter <[EMAIL PROTECTED]> wrote on 12/05/2004 > > > > > > 11:24:31: > > > > > > > > > > > > > Fixed in CVS. > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > > > > > > > > Sent: Wednesday, 12 May 2004 9:23 AM > > > > > > > > To: [EMAIL PROTECTED] > > > > > > > > Subject: RC2 Windows - Maven.bat does not allow spaces in > > > > > > JAVA_HOME > > > > > > > > > > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > I have found an issue in RC2 in maven.bat on line 56: > > > > > > > > > > > > > > > > if exist %JAVA_HOME%\nul goto chkMHome > > > > > > > > > > > > > > > > As there is no quotes around it, it fails when there > > > > is spaces > > > > > > > > in the JAVA_HOME value e.g. program files. > > > > > > > > > > > > > > > > I got it to work by changing the line to the following: > > > > > > > > > > > > > > > > if exist "%JAVA_HOME%" goto chkMHome > > > > > > > > > > > > > > > > I am not sure what the \nul was for but it works fine for > > > > > > me without > > > > > > > > it on Windows 2000. > > > > > > > > > > > > > > > > Cheers Dave ********************************************************************** CAUTION - This message is intended for the addressee named above. It may contain privileged or confidential information. If you are not the intended recipient of this message you must not use, copy, distribute or disclose it to anyone. ********************************************************************** --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
