Ryan, this approach is good when there is only one developer. With a team of committers you can't control what and when gets committed. Very often developers violate this "no-defect" policy and break the build. This is what CI engine is for - to catch such violators and let them know immediately that they need to fix the problems introduced.
But again, notifications have to be sent immediately by email and no deployment/site-deployment have to be done. — Yegor Bugayenko, PMP®, SCEA On Thu, Mar 24, 2011 at 5:23 PM, Ryan Connolly <ryn...@gmail.com> wrote: > Why not simply fail the build (locally) upon any Checkstyle violations > before it even gets committed and built by CI? I'm not sure about FB but I > would guess you would have the option to fail the build for FB violations > as > well? This way, only code that conforms to your standards gets commited to > VCS. > > > > On Thu, Mar 24, 2011 at 11:39 AM, <stefan.han...@tolina.com> wrote: > > > >> What is the point of JUnit failure reports in CI environment? It's > > absolutely un-acceptable situation when your source codebase contains a > > defect in "trunk". It's not a matter of reporting any more, but of an > > immediate action. > > >> If you still need your build to be valid with defects inside (unit > test > > failures) you should use this surefire configuration option: > > > > I do want to fail the build of course (otherwise broken artifacts would > > get deployed). > > And I do want my developers to take immediate action as well of course. > > > > But to do so I must inform them about the failure in a convenient way, > > don't I? > > Therefore we have a CI system, which sends an email of the broken build. > > Devs then enter the TeamCity web-page and there I want to present a nice > > (i.e. HTML) failure report (i.e. the current CheckStyle errors that need > > to be resolved instantly), to make the build green again. > > > > I definitely don't want the developers to scan the build-log to find the > > lines from Checkstyle there. > > So right now the only 'working' solution I found, it to create a > > 'plain'-txt Checkstyle report, which can be part of the reports of the > > broken build. > > This feels very clumsy (and Checkstyle should be considered just a > > placeholder for other reporting tools, like FindBugs or JUnit). > > > > So of course I wouldn't need the whole site to be created, but just the > > (HTML)-report of the tool that failed the build. This right now I'm not > > able to solve. > > > > How do you inform your developers about CheckStyle or FindBugs errors / > > broken build in a convenient way as part of your CI ? > > > > Cheers Stefan > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: users-unsubscr...@maven.apache.org > > For additional commands, e-mail: users-h...@maven.apache.org > > > > >
